67933 - null plugin registered twice

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

A checkin sometime between 2001-02-06 16:45 and 17:17 (based on tinderbox logs)
caused the null plugin registration message to show up twice:


********** Got plugins path: /builds/seamonkey/obj/debug/dist/bin/plugins
IsPluginFile(/builds/seamonkey/obj/debug/modules/plugin/default/unix/libnullplugin.so)
LoadPlugin()
/builds/seamonkey/obj/debug/modules/plugin/default/unix/libnullplugin.so
returned 81b28e0
GetMIMEDescription() returned "*:.*:All types"
Registering plugin 0 for: "*","All types",".*"
********** Got plugins path: /builds/seamonkey/obj/debug/dist/bin/plugins
IsPluginFile(/builds/seamonkey/obj/debug/modules/plugin/default/unix/libnullplugin.so)
LoadPlugin()
/builds/seamonkey/obj/debug/modules/plugin/default/unix/libnullplugin.so
returned 81b28e0
GetMIMEDescription() returned "*:.*:All types"
Registering plugin 0 for: "*","All types",".*"


This seems wrong -- like we're doing extra work.  I suspect the checkins by
[e-mail] to nsPluginHostImpl.cpp and nsPluginsDir.h.

Comment 1

[Peter Lubczynski]

The code I checked in recently is XP_WIN only. This is an old problem. Notice 
about:plugins shows two Default Plugins. I don't believe it's registered twice 
on Windows or Mac.

Comment 2

[Becki Sanford]

This is not limited to the null plugin. See same behavior after installing the
Java 2 plugin from
ftp://ftp.netscape.com/pub/netscape6/english/6.0/unix/linux22/xpi/jre.xpi

Also, when you do "about:plugins", Mozilla is running through the "Registering
plugin # for:" code another 6 times.

BUILD ID: Mozilla 0.8 on Linux

Comment 3

[Peter Lubczynski]

Yeah, I figure out how to use gdb.

Working on this. Looks like mPluginsLoaded = PR_TRUE was not being set ouside 
the #IFDEF. Patch on it's way. Setting milestone.

Comment 4

[Peter Lubczynski]

Attachment: patch to register plugins once on UNIX

Comment 5

[Peter Lubczynski]

David/Andrei reviews?

Comment 6

[av (gone)]

Peter, why do you do mPluginsLoaded = PR_TRUE; separately for the Mac? Isn't it 
enough that you put it after all ifdef's once?

Comment 7

[Peter Lubczynski]

That probably is true, but the Mac doesn't have the problem. Will try that 
approach on Mac.

Comment 8

[Peter Lubczynski]

Attachment: better patch (just re-positioned #IFDEFs)

Comment 9

[av (gone)]

Looks like you attached not exactly what you intended.

Comment 10

[Peter Lubczynski]

Attachment: real patch, ingnore previous

Comment 11

[Marc Attinasi]

[s]r=attinasi

Comment 12

[av (gone)]

Peter, would please attach cvs diff -u ? My line numbering is screwed so I 
cannot be sure I'm looking at the right place.

Comment 13

[Peter Lubczynski]

Attachment: a unified patch

Comment 14

[av (gone)]

ra=av

Comment 15

[Peter Lubczynski]

Patch checked in. 

new revision: 1.212; previous revision: 1.211

Comment 16

[shrirang khanzode]

verified on linux 0412, null plugin registers only once.