scratchpad doesn't display the value false

RESOLVED FIXED in Firefox 10

Status

P2
normal
RESOLVED FIXED
8 years ago
8 months ago

People

(Reporter: allen, Assigned: harth)

Tracking

6 Branch
Firefox 10
x86
macOS

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
The 'display' menu item does not display the values of false, null, "", etc.  It appears to skip displaying all falsey values.  This is not what I would want to see, as a user of this feature.  Please display the actual value.

Repo:
1) open a scratchpad
2) type: false
3) select it and then select the 'display' menu item
4) no output appears
We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P2
Duplicate of this bug: 690569
(Assignee)

Updated

7 years ago
Assignee: nobody → fayearthur+bugs
(Assignee)

Comment 3

7 years ago
I imagine we'd want to do this for the 'inspect' command too?
(Assignee)

Comment 4

7 years ago
Created attachment 571479 [details] [diff] [review]
display falsy values

This patch makes scratchpad inspect and display all falsy values.
(Assignee)

Updated

7 years ago
Attachment #571479 - Flags: review?(rcampbell)
Comment on attachment 571479 [details] [diff] [review]
display falsy values

In test file:

+function testFalsy(sp)
+{
+  gScratchpadWindow.removeEventListener("load", arguments.callee, false);

should removeEventListener("load", testFalsy, false) as arguments.callee is going away.
Comment on attachment 571479 [details] [diff] [review]
display falsy values

looks good!
Attachment #571479 - Flags: review?(rcampbell) → review+
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team]
and the REAL push:

https://hg.mozilla.org/integration/fx-team/rev/0447ea74c626
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
and the REAL push to m-c :)

https://hg.mozilla.org/mozilla-central/rev/0447ea74c626
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.