679467 - scratchpad doesn't display the value false

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Allen Wirfs-Brock]

The 'display' menu item does not display the values of false, null, "", etc.  It appears to skip displaying all falsey values.  This is not what I would want to see, as a user of this feature.  Please display the actual value.

Repo:
1) open a scratchpad
2) type: false
3) select it and then select the 'display' menu item
4) no output appears

Comment 1

[Dave Camp (:dcamp)]

We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.

Comment 3

[Heather Arthur [:harth]]

I imagine we'd want to do this for the 'inspect' command too?

Comment 4

[Heather Arthur [:harth]]

Attachment: display falsy values

This patch makes scratchpad inspect and display all falsy values.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 571479 [details] [diff] [review]
display falsy values

In test file:

+function testFalsy(sp)
+{
+  gScratchpadWindow.removeEventListener("load", arguments.callee, false);

should removeEventListener("load", testFalsy, false) as arguments.callee is going away.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 571479 [details] [diff] [review]
display falsy values

looks good!

Comment 7

[Rob Campbell [:rc] (:robcee)]

and the REAL push:

https://hg.mozilla.org/integration/fx-team/rev/0447ea74c626

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

and the REAL push to m-c :)

https://hg.mozilla.org/mozilla-central/rev/0447ea74c626