679806 - Don't count outdated articles as done in dashboard

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Kadir Topal [:atopal]]

In the localization dashboard the top row shows percentage of top 20 articles localized. But it counts outdated localizations as localized. Instead it should only count articles as done that are up to date. So if one of the top 20 articles is out of date the bar should switch to orange and the percentage should drop.

Comment 1

[James Socol [:jsocol, :james]]

Erik, if you have time, as master of these dashboards I'm hoping you can grab this.

Comment 2

[Erik Rose [:erik][:erikrose]]

Yep, planned on it already. Not quite ready to promise a milestone, though.

Comment 3

[James Socol [:jsocol, :james]]

This missed 9-13, and 9-20 :(. If this bug is assigned to you please retarget and take care of it ASAP.

Comment 4

[Erik Rose [:erik][:erikrose]]

Kadir: same for the other rows of the Übersicht table? For example, should Vorlagen also not count out-of-date articles as done?

Comment 5

[Kadir Topal [:atopal]]

Yes, same for that please. Thanks!

Comment 6

[Erik Rose [:erik][:erikrose]]

I realized too late that it's night time in Europe and asked this stuff on IRC. :-)

ErikRose: Topal: Have a second for some horrors?
ErikRose: So I'm working on the l10n dash, and I've run into an interesting corner case regarding the "needs review" designation.
ErikRose: Also, if you're in Europe, you're definitely asleep.
ErikRose: Anyway, currently, on the Most Visited dashboard, a translation will show as "needs review" even if it is fully up to date with the English article. As long as it has any pending revisions in its own language, it's "needing review".
ErikRose: However, in the orange and green graphs up in the Overview readout, I am tempted to count such in-need-of-review translations as up to date, as long as they are in fact up to date with regard to their English versions. After all, show the status of translations in relation to the English is the point of those graphs, as I understand it.
ErikRose: Do you have any thoughts on the matter?

Comment 7

[Kadir Topal [:atopal]]

ah, same from the email:

I agree with you, we should do that, but the situation is a actually a bit more complex, because sometimes someone will only fix a spelling mistake and when that revision is accepted the article appears to be up to date, even though it's completely outdated. In those cases the only option the localizer has is to leave the review hanging or accept the spelling fix and loose track of which article needs an update.

Maybe we should move to a different system, where the outdating of a translation is automated, but the "up-to-dating" of a translation manual, eg. a checkbox in the description field, that the local leader can set.

What do you think?

Comment 8

[Erik Rose [:erik][:erikrose]]

I think we could actually do that pretty easily: right now, for each revision of a translation, we track which English revision it brings the translation up to date with. We call this the based_on field. We could let somebody adjust the corresponding based_on revision manually rather than relying wholly on heuristics like we do now. It would need some UI thought, but it seems quite feasible. Worth it? You'd know best.

Comment 9

[Erik Rose [:erik][:erikrose]]

master: http://github.com/jsocol/kitsune/commit/bb9535b
next: http://github.com/jsocol/kitsune/commit/dcf5a05

Comment 10

[Rebecca Billings [:rbillings]]

Verified that outdated [M and MT level changes] articles no longer display in the localization overview as translated.

Comment 11

[Kadir Topal [:atopal]]

Erik, yes, worth it. I think what I described here is pretty much the same thing Thomas requested here: https://bugzilla.mozilla.org/show_bug.cgi?id=682730

Any estimate for how long it would take to implement this change in a basic form? (eg just adding a checkbox to the description field of localized articles)