67981 - unable to insert emoticons (two cases)

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[(not reading, please use [e-mail] instead)]

bring up html message compose
add a emoticon, like :), using the emoticon picker.  it works
try to add a second one, nothing gets added.
if I type a space, then another emoticon can be inserted.

is this by design?

Comment 1

[(not reading, please use [e-mail] instead)]

1) can't insert one right after another
2) can't insert at the start of the message (the first line, the first
character)

Comment 2

[Syd Logan]

Assigning to Anatoliy

Comment 3

[Anatoliy Averbukh]

In the patch I insert the following source, if user chooses a smile from menu 
(different codes for different types of course):

  <span sml="s1"><span>:-)</span></span>

Together with CSS in EditorContent.css, it provides:
- background image instead of text code, that cannot be editable (just 
insertion and delete are allowed);
- different views for the element: (a smiley) image in normal editor view and 
text code in preview mode;
- elimination of all previous design restrictions concerned with place, where 
smileys can be inserted (like collapsed selection and text node)

Comment 4

[Anatoliy Averbukh]

Attachment: smiley images

Comment 5

[Charles Manske]

r=cmanske

Comment 6

[Simon Fraser [no longer active]]

There is one problem with this approach, which is that we might now conflict with 
spans in user documents having a "sml" attribute. Should this be renamed to be 
more explicitily mozilla-specific, like "-moz-smiley" ?

Comment 7

[Anatoliy Averbukh]

Sure, no problem, it is done.

Comment 8

[Anatoliy Averbukh]

Attachment: smiley attribute name is changed

Comment 9

[kinmoz]

Things work pretty well with the 02/19/01 15:31 patch.

Some suggestions to consider before checkin:

1. The editor calls in doCommand() should probably be wrapped with try/catch.
   We've been having problems with uncaught exceptions killing the editor UI
   so I just want to avoid that situation.

2. We can collapse alot of the similar -moz-smiley rules into a single rule
   if we avoid checking for specific values, which could save you lots of
   typing:

    span[-moz-smiley] {
      min-height: 17px; margin-left: 2px; margin-top: 2px;
      padding-left: 20px;
      background-repeat: no-repeat;
      background-position: center center;
    }

    span[-moz-smiley] > span {
        display: none;
    }

    span[-moz-smiley="s1"] {
      background-image: url(chrome://editor/content/images/smile.gif);
    }

    span[-moz-smiley="s2"] {
      background-image: url(chrome://editor/content/images/frown.gif);
    }

    ...

sr=[e-mail]

Comment 10

[Syd Logan]

fix checked in by syd on behalf of [e-mail]

Comment 11

[sujay]

Seth, is this working for you now? can you mark this verified-fixed ? thanks!

Comment 12

[sujay]

can someone please verify this is fixed now? and mark verified-fixed...thanks.

Comment 13

[Anatoliy Averbukh]

Suzanne verified that today