https://crash-stats.mozilla.com/admin/branch_data_sources has a "Missing Entries" list but clicking "add" on any of them does not do anything. Previously, that would show the form with some data to actually click a button to add the entry, but the form doesn't appear now.
Created attachment 555515 [details] [diff] [review] Correct admin section This patch does two things: * Reinstates code that was removed from 2.2, but is required for the proper functioning of the "add" behavior * Makes use of jberkus' new stored procedure for adding items to the product_info table.
Comment on attachment 555515 [details] [diff] [review] Correct admin section >Index: webapp-php/application/models/branch.php >=================================================================== >+ $rv = $this->db->query("/* soc.web branch.add */ >+ SELECT * FROM edit_product_info(null, ?, ?, ?, ?, ?, ?, ?)", $product, $version, $release, $start_date, $end_date, $featured, $throttle); Just a nit - I didn't notice that this was a function so was scratching my head at first. Not having the "* FROM" is more typical, like: SELECT edit_product_info(a,b,c,d,); Especially if it only returns one value (as this function does) and/or you don't care about the return value. Anyway works/looks fine otherwise as-is, so I'll leave that up to you to change or not as you see fit.
Committed revision 3474.
Created attachment 556666 [details] adding missing entry The dialog for adding missing products to the branches is back and functioning again.
QA verified. Kairo when you have a moment please take a look at the re-instated behavior on stage. If need be please re-open.
Yup, verified by satisfying bug 683107 on stage ;-)