The default bug view has changed. See this FAQ.

Clicking "add" on missing entries in admin UI does nothing

VERIFIED FIXED in 2.2.2

Status

Socorro
General
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Robert Kaiser, Assigned: brandon)

Tracking

Bug Flags:
in-litmus ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
https://crash-stats.mozilla.com/admin/branch_data_sources has a "Missing Entries" list but clicking "add" on any of them does not do anything.

Previously, that would show the form with some data to actually click a button to add the entry, but the form doesn't appear now.
(Assignee)

Updated

6 years ago
Assignee: nobody → bsavage

Updated

6 years ago
Target Milestone: --- → 2.2.2
(Assignee)

Comment 1

6 years ago
Created attachment 555515 [details] [diff] [review]
Correct admin section

This patch does two things:

* Reinstates code that was removed from 2.2, but is required for the proper functioning of the "add" behavior
* Makes use of jberkus' new stored procedure for adding items to the product_info table.
Attachment #555515 - Flags: review?(rhelmer)
Comment on attachment 555515 [details] [diff] [review]
Correct admin section

>Index: webapp-php/application/models/branch.php
>===================================================================
>+                $rv = $this->db->query("/* soc.web branch.add */
>+                    SELECT * FROM edit_product_info(null, ?, ?, ?, ?, ?, ?, ?)", $product, $version, $release, $start_date, $end_date, $featured, $throttle);		

Just a nit - I didn't notice that this was a function so was scratching my head at first.

Not having the "* FROM" is more typical, like:
SELECT edit_product_info(a,b,c,d,);

Especially if it only returns one value (as this function does) and/or you don't care about the return value.

Anyway works/looks fine otherwise as-is, so I'll leave that up to you to change or not as you see fit.
Attachment #555515 - Flags: review?(rhelmer) → review+

Updated

6 years ago
Flags: in-testsuite?
Flags: in-litmus?
(Assignee)

Comment 3

6 years ago
Committed revision 3474.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Created attachment 556666 [details]
adding missing entry

The dialog for adding missing products to the branches is back and functioning again.
QA verified. Kairo when you have a moment please take a look at the re-instated behavior on stage. If need be please re-open.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 6

6 years ago
Yup, verified by satisfying bug 683107 on stage ;-)
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.