Closed Bug 679863 Opened 13 years ago Closed 13 years ago

SDK versions need to be able to specify command-line options for cfx

Categories

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Builder 0.9.12

People

(Reporter: smcarthur, Assigned: zalun)

References

Details

The cfx command can differ from SDK version to version. We either need to be able to specify new options in a version, or let each version create the command itself.

Currently, its built here: https://github.com/mozilla/FlightDeck/blob/0.9.8/apps/xpi/xpi_utils.py#L74

It could be part of the manage command: `manage.py add_core_lib 1.0 --options "--stripx-xpi"`
Assignee: nobody → zaloon
Priority: -- → P2
Target Milestone: --- → Builder 0.9.11
Once this is deployed (specifically once the latest version of the SDK is no longer handed the obsolete --strip-xpi option), we'd like to remove --strip-xpi from the SDK, tracked in bug 675294.
Blocks: 675294
Target Milestone: Builder 0.9.11 → Builder 0.9.12
Fixed in https://github.com/mozilla/FlightDeck/commit/69e7664a48fe3a8b369f46abb8d54b945ec3c3fc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
zalun: when will this get deployed? I don't want to remove --strip-xpi from the SDK until we're sure that the production Flightdeck instance has the ability to stop passing it in, so I suspect I need to wait a little bit longer before landing bug 675294.
warner: This will go live this Wednesday. We have a push of all fixes every weds.

I'd bet you can land your patch whenever you want: We won't pull it in until this lands anyways.
great, thanks!
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.