679873 - Automatically select newly created account, when created from Account Manager

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, enhancement)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Have several accounts already set up
2. Go to Edit|Account Settings... window, select an account
3. Click button Account Actions | Add Mail Account...
4. Walk through wizard, finish it successfully

Actual result:
- The account selected in step 2 is still selected

Expected result:
- The newly created account is selected

Comment 2

[:aceman]

Sure, let's do this. This will be consistent with the behaviour of the filter list editor and the identity list editor.

One complication is that the account is created in a new dialog so I hope I can get from it which account was created.

Comment 3

[:aceman]

Instead of patching all the various wizards and provisioners to send back the id of the new account, I'll rather patch onAddAccount(), AddMailAccount(), AddIMAccount() to store the current list of accounts, then call the wizards and then see which ID is new and then select it. A bit hacky but the wizards are too ugly to touch them.

Comment 5

[:aceman]

Attachment: 679873.patch

Would this work for you?

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9077858 [details] [diff] [review]
679873.patch

Looks OK to me, but I'm not an expert in the field.

Comment 7

[Ian Neal]

Comment on attachment 9077858 [details] [diff] [review]
679873.patch

Tested with creating IMAP, rss and news accounts and didn't hit any issues.
LGTM r=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/41829078a11a
Select newly created server in the account manager. r=jorgk,IanN

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9077858 [details] [diff] [review]
679873.patch

I imagine these FB requests are no longer needed