Last Comment Bug 679908 - probing.png is missing
: probing.png is missing
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 23.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-17 15:40 PDT by Philipp Kewisch [:Fallen]
Modified: 2013-05-13 06:41 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (2.98 KB, patch)
2013-04-23 10:55 PDT, Richard Marti (:Paenglab)
bwinton: review+
Details | Diff | Review

Description Philipp Kewisch [:Fallen] 2011-08-17 15:40:33 PDT
The new account wizard references probing.png:

http://mxr.mozilla.org/comm-central/search?string=probing.png&find=mail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

which is nowhere to be found in the tree:

http://mxr.mozilla.org/comm-central/find?string=probing.png
Comment 1 Richard Marti (:Paenglab) 2013-01-03 11:28:11 PST
It looks probing.png was never in the tree. Should we use loading.png instead (http://mxr.mozilla.org/comm-central/find?string=loading.png)?
Comment 2 Blake Winton (:bwinton) (:☕️) 2013-02-03 11:22:51 PST
Given that the others are all coloured circles, I think we want a new image for this.

Andreas, could you whip some icons up that are similar to the ones at http://mxr.mozilla.org/comm-central/find?string=%2F%28secure|insecure|failed%29.png&tree=comm-central&hint= ?

Thanks,
Blake.
Comment 3 Richard Marti (:Paenglab) 2013-04-21 04:00:02 PDT
It looks like Bug 549045 has removed the icons from XUL file. I think we can remove also the rules from CSS file.

Blake, what do you think about this?
Comment 4 Blake Winton (:bwinton) (:☕️) 2013-04-22 10:49:43 PDT
It did?  Are you _sure_?  Cause that doesn't sound right…
Comment 5 Richard Marti (:Paenglab) 2013-04-22 11:39:38 PDT
When you look in http://hg.mozilla.org/comm-central/rev/75875cb17fb0 then on incomingarea the class="icon" is here removed: http://hg.mozilla.org/comm-central/rev/75875cb17fb0#l13.268 and in actual file where is no icon class: http://hg.mozilla.org/comm-central/file/3267f9ecf52c/mailnews/base/prefs/content/accountcreation/emailWizard.xul#l263

The same is for outgoingarea.

Also when you look at Ben's screenshot where is no icon to show the status: https://bugzilla.mozilla.org/attachment.cgi?id=517570

The only occurence of "icon" is here: http://hg.mozilla.org/comm-central/file/3267f9ecf52c/mailnews/base/prefs/content/accountcreation/emailWizard.js#l1425 and line 1433. But this creates the class warningicon.

For this I would say this icons are no more used.
Comment 6 Blake Winton (:bwinton) (:☕️) 2013-04-22 13:46:13 PDT
Okay, that sounds good, then.  (Unless we want to re-add them…  ;)
Comment 7 Richard Marti (:Paenglab) 2013-04-23 10:55:25 PDT
Created attachment 740930 [details] [diff] [review]
patch

I removed the rules for the class icon. On osx where was a failed.png file but it wasn't referenced in jar.mn and linux and windows didn't have this file.

Blake, please can you recheck if this class is really not used? I checked probing and weak in MXR and haven't found any appearance where the icon class becomes this state. The same with strong.
Comment 8 Blake Winton (:bwinton) (:☕️) 2013-05-12 19:22:11 PDT
Comment on attachment 740930 [details] [diff] [review]
patch

Yeah, I agree, the classes are really not used anywhere.  r=me.

Thanks,
Blake.
Comment 9 Ryan VanderMeulen [:RyanVM] 2013-05-13 06:40:01 PDT
https://hg.mozilla.org/comm-central/rev/9c0455b81f2f

Note You need to log in before you can comment on or make changes to this bug.