679908 - probing.png is missing

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The new account wizard references probing.png:

http://mxr.mozilla.org/comm-central/search?string=probing.png&find=mail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

which is nowhere to be found in the tree:

http://mxr.mozilla.org/comm-central/find?string=probing.png

Comment 1

[Richard Marti (:Paenglab)]

It looks probing.png was never in the tree. Should we use loading.png instead (http://mxr.mozilla.org/comm-central/find?string=loading.png)?

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Given that the others are all coloured circles, I think we want a new image for this.

Andreas, could you whip some icons up that are similar to the ones at http://mxr.mozilla.org/comm-central/find?string=%2F%28secure|insecure|failed%29.png&tree=comm-central&hint= ?

Thanks,
Blake.

Comment 3

[Richard Marti (:Paenglab)]

It looks like Bug 549045 has removed the icons from XUL file. I think we can remove also the rules from CSS file.

Blake, what do you think about this?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

It did?  Are you _sure_?  Cause that doesn't sound right…

Comment 5

[Richard Marti (:Paenglab)]

When you look in http://hg.mozilla.org/comm-central/rev/75875cb17fb0 then on incomingarea the class="icon" is here removed: http://hg.mozilla.org/comm-central/rev/75875cb17fb0#l13.268 and in actual file where is no icon class: http://hg.mozilla.org/comm-central/file/3267f9ecf52c/mailnews/base/prefs/content/accountcreation/emailWizard.xul#l263

The same is for outgoingarea.

Also when you look at Ben's screenshot where is no icon to show the status: https://bugzilla.mozilla.org/attachment.cgi?id=517570

The only occurence of "icon" is here: http://hg.mozilla.org/comm-central/file/3267f9ecf52c/mailnews/base/prefs/content/accountcreation/emailWizard.js#l1425 and line 1433. But this creates the class warningicon.

For this I would say this icons are no more used.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Okay, that sounds good, then.  (Unless we want to re-add them…  ;)

Comment 7

[Richard Marti (:Paenglab)]

Attachment: patch

I removed the rules for the class icon. On osx where was a failed.png file but it wasn't referenced in jar.mn and linux and windows didn't have this file.

Blake, please can you recheck if this class is really not used? I checked probing and weak in MXR and haven't found any appearance where the icon class becomes this state. The same with strong.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 740930 [details] [diff] [review]
patch

Yeah, I agree, the classes are really not used anywhere.  r=me.

Thanks,
Blake.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/9c0455b81f2f