probing.png is missing

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Fallen, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 23.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The new account wizard references probing.png:

http://mxr.mozilla.org/comm-central/search?string=probing.png&find=mail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

which is nowhere to be found in the tree:

http://mxr.mozilla.org/comm-central/find?string=probing.png
Component: General → Theme
QA Contact: general → theme
(Assignee)

Comment 1

4 years ago
It looks probing.png was never in the tree. Should we use loading.png instead (http://mxr.mozilla.org/comm-central/find?string=loading.png)?
Flags: needinfo?(bwinton)
Given that the others are all coloured circles, I think we want a new image for this.

Andreas, could you whip some icons up that are similar to the ones at http://mxr.mozilla.org/comm-central/find?string=%2F%28secure|insecure|failed%29.png&tree=comm-central&hint= ?

Thanks,
Blake.
Flags: needinfo?(bwinton) → needinfo?(bugs)
(Assignee)

Comment 3

4 years ago
It looks like Bug 549045 has removed the icons from XUL file. I think we can remove also the rules from CSS file.

Blake, what do you think about this?
Flags: needinfo?(bugs) → needinfo?(bwinton)
It did?  Are you _sure_?  Cause that doesn't sound right…
Flags: needinfo?(bwinton)
(Assignee)

Comment 5

4 years ago
When you look in http://hg.mozilla.org/comm-central/rev/75875cb17fb0 then on incomingarea the class="icon" is here removed: http://hg.mozilla.org/comm-central/rev/75875cb17fb0#l13.268 and in actual file where is no icon class: http://hg.mozilla.org/comm-central/file/3267f9ecf52c/mailnews/base/prefs/content/accountcreation/emailWizard.xul#l263

The same is for outgoingarea.

Also when you look at Ben's screenshot where is no icon to show the status: https://bugzilla.mozilla.org/attachment.cgi?id=517570

The only occurence of "icon" is here: http://hg.mozilla.org/comm-central/file/3267f9ecf52c/mailnews/base/prefs/content/accountcreation/emailWizard.js#l1425 and line 1433. But this creates the class warningicon.

For this I would say this icons are no more used.
Okay, that sounds good, then.  (Unless we want to re-add them…  ;)
(Assignee)

Updated

4 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 7

4 years ago
Created attachment 740930 [details] [diff] [review]
patch

I removed the rules for the class icon. On osx where was a failed.png file but it wasn't referenced in jar.mn and linux and windows didn't have this file.

Blake, please can you recheck if this class is really not used? I checked probing and weak in MXR and haven't found any appearance where the icon class becomes this state. The same with strong.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #740930 - Flags: review?(bwinton)
Comment on attachment 740930 [details] [diff] [review]
patch

Yeah, I agree, the classes are really not used anywhere.  r=me.

Thanks,
Blake.
Attachment #740930 - Flags: review?(bwinton) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9c0455b81f2f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Target Milestone: Thunderbird 24.0 → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.