67991 - not prompted to send as Plain Text | HTML | Both

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Asa Dotzler [:asa]]

Tested this morning's Mac and win32 builds. 020704

When sending a mail message with HTML content the user is not prompted for send
as type options.

1. compose new message
2. add a table or HR or some other HTML
3. send message

results: not prompted to send as plain text, html or both
expecrted: prompted.

Comment 1

[Asa Dotzler [:asa]]

adding keywords, setting severity.

Comment 2

[Jacek Piskozub]

This is even worse. All emails are being sent as HTML even with "Convert the
message to plain text" setting on. I am sure this is the same bug therefore I do
not report it as a new one. However does this  mean that the title of the bug
should be changed? 

Seen on both Win32 2001020606 and 2001020704 installer builds (Windows ME).

Comment 3

[Jean-Francois Ducarroz]

I am looking at it... seems to be something wrong in JS: The backend correctly
build the list of user that doesn't support HTML but JS see this string as empty!!!

Comment 4

[Asa Dotzler [:asa]]

*** Bug 67980 has been marked as a duplicate of this bug. ***

Comment 5

[Asa Dotzler [:asa]]

*** Bug 67980 has been marked as a duplicate of this bug. ***

Comment 6

[Christopher Blizzard (:blizzard)]

*** Bug 67980 has been marked as a duplicate of this bug. ***

Comment 7

[Asa Dotzler [:asa]]

*** Bug 67980 has been marked as a duplicate of this bug. ***

Comment 8

[Jean-Francois Ducarroz]

Here is the fix:

Index: MsgComposeCommands.js
===================================================================
RCS file:
/cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v
retrieving revision 1.143
diff -w -u -4 -r1.143 MsgComposeCommands.js
--- MsgComposeCommands.js	2001/02/05 07:53:02	1.143
+++ MsgComposeCommands.js	2001/02/07 22:13:00
@@ -1623,15 +1623,17 @@
     if (sendFormat == msgCompSendFormat.AskUser)
     {
         //Well, before we ask, see if we can figure out what to do for ourselves
         
-        var noHtmlRecipients = new String("");
+        var noHtmlRecipients;
         var noHtmlnewsgroups;
         var preferFormat;
 
         //Check the address book for the HTML property for each recipient
         try {
-            preferFormat = msgCompose.CheckAndPopulateRecipients(true, true,
noHtmlRecipients);
+            var obj = new Object;
+            preferFormat = msgCompose.CheckAndPopulateRecipients(true, true, obj);
+            noHtmlRecipients = obj.value;
         } catch(ex)
         {
             var msgCompFields = msgCompose.compFields;
             noHtmlRecipients = msgCompFields.GetTo() + "," +
msgCompFields.GetCc() + "," + msgCompFields.GetBcc();

Comment 9

[Scott MacGregor]

sr=mscott

Comment 10

[(not reading, please use [e-mail] instead)]

r=sspitzer

Comment 11

[Asa Dotzler [:asa]]

please check this in.  thanks!  a=asa and all that.

Comment 12

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 13

[Jean-Francois Ducarroz]

*** Bug 67931 has been marked as a duplicate of this bug. ***

Comment 14

[Sheela Ravindran]

commercial trunk buildid:  2001021909 win98
                           2001021904 mac
                           2001021908 linux

verified