Add entities parameter to preferences

RESOLVED FIXED

Status

Mozilla QA Graveyard
Mozmill Crowd Extension
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

We should allow users of Mozmill Crowd to specify the number of entities when running endurance tests.
(Assignee)

Comment 1

7 years ago
Created attachment 554034 [details] [diff] [review]
Add entities parameter to preferences. v1.0
Assignee: nobody → dave.hunt
Attachment #554034 - Flags: review?(hskupin)
Comment on attachment 554034 [details] [diff] [review]
Add entities parameter to preferences. v1.0

>+       <label control="entitiesAmount"
>+              value="&enduranceTestrunEntities.label;"/>
>+       <spacer flex="1"/>
>+       <textbox id="entities"

The value of the control attribute has to be 'entities'. Same applies to the other endurance test settings which are using labels. Please update all of them accordingly.

Also this patch needs an update anyway once the patch on bug 676827 has been checked-in. r=me with those changes.
Attachment #554034 - Flags: review?(hskupin) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 554394 [details] [diff] [review]
Add entities parameter to preferences. v1.1

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Comment on attachment 554034 [details] [diff] [review]
> Add entities parameter to preferences. v1.0
> 
> >+       <label control="entitiesAmount"
> >+              value="&enduranceTestrunEntities.label;"/>
> >+       <spacer flex="1"/>
> >+       <textbox id="entities"
> 
> The value of the control attribute has to be 'entities'. Same applies to the
> other endurance test settings which are using labels. Please update all of
> them accordingly.

Done.

> Also this patch needs an update anyway once the patch on bug 676827 has been
> checked-in. r=me with those changes.

This should apply cleanly.
Attachment #554034 - Attachment is obsolete: true
Attachment #554394 - Flags: review?(hskupin)
Attachment #554394 - Flags: review?(hskupin) → review+
Landed as:
https://github.com/whimboo/mozmill-crowd/commit/9ac1768721becd08fad2205b1156db913e4e21c0
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Blocks: 683929
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.