Language packs: Spellcheck dictionaries don't get auto-detected

NEW
Unassigned

Status

Thunderbird
Preferences
6 years ago
2 years ago

People

(Reporter: Ozan Caglayan, Unassigned, NeedInfo)

Tracking

({intl})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patchlove])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110711153838

Steps to reproduce:

In the preferences window, the spellchecking dictionary is not automatically selected according to the UI locale. Actually, the langpacks contains all-l10n.js files which sets spellchecker.dictionary property. But those files are not processed at all unless installed in defaults/preferences instead of defaults/pref.
(Reporter)

Comment 1

6 years ago
Created attachment 554035 [details] [diff] [review]
Install .js into preferences/ not pref/
(Reporter)

Comment 2

6 years ago
The patch at least enables thunderbird to process the all-l10n.js files from the extensions/langpack-$locale/ folders. But the language packs are active add-ons all the time so all the .js files are processed not only the current langpack's one leading to unexpected spellchecker dictionary selections.
(Reporter)

Updated

6 years ago
Component: General → Spelling checker
Product: Thunderbird → Core
Version: 5.0 → 5 Branch
Component: Spelling checker → General
Product: Core → Thunderbird
Version: 5 Branch → unspecified
Version: unspecified → 5.0
Ozan can you try to find when this stopped working ?
Component: General → Preferences
QA Contact: general → preferences
(Reporter)

Comment 4

6 years ago
Actually I don't know any version that this was working. 3.x branch is faulty too. I'll now try with the new 6.0 but don't think that it's fixed there too.
Ok, so this appears to be a problem just with language packs, the main repacks of Thunderbird are fine.

The issue with the patch is that it will break the repacks of the Thunderbird application because all-l10n.js needs to go into the defaults/pref directory there.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All
Summary: Spellcheck dictionaries don't get auto-detected → Language packs: Spellcheck dictionaries don't get auto-detected

Comment 6

6 years ago
Language packs need to be set up such that you can install an arbitrary amount of them, as any add-on. Thus, neither the general.useragent.locale nor the spellchecker.dictionary pref belong into language packs.

I guess that doing a default value for the selected dictionary based on bcp47 matching goodness would be much more helpful?

Comment 7

3 years ago
ozan, are you able to imporve the patch?

(In reply to Axel Hecht [:Pike] from comment #6)
> Language packs need to be set up such that you can install an arbitrary
> amount of them, as any add-on. Thus, neither the general.useragent.locale
> nor the spellchecker.dictionary pref belong into language packs.
> 
> I guess that doing a default value for the selected dictionary based on
> bcp47 matching goodness would be much more helpful?
Flags: needinfo?(ozan)
Keywords: intl
Whiteboard: [patchlove]
You need to log in before you can comment on or make changes to this bug.