Closed
Bug 680147
Opened 13 years ago
Closed 13 years ago
[l10n] FX Landing Page Experience
Categories
(www.mozilla.org :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
4.0
People
(Reporter: christine.brodigan, Assigned: pascalc)
References
()
Details
(Whiteboard: r=94066,94067,94916,94920,94923,94929,95581,95589 b=trunk)
Goals: *Increase FX downloads *Create better user experience based on browser version detection (getting users to the information they need as quickly as possible) *Take advantage of Greg's findings from Bug 659978 demonstrating a 6% increase in downloads. Proposed Experience: *Implement across all locales users of other browsers to https://www-trunk.stage.mozilla.com/fr/firefox/tests/abtest3.html *Implement across all locales users of 3.6 and below to https://www-trunk.stage.mozilla.com/fr/firefox/tests/abtest3.html * Implement across all locales users of 4.0+ to https://www.mozilla.com/de/firefox/ Website Resources Plan: Implement browser version detection (easily done) *Launch new simplified landing page (ex: https://www-trunk.stage.mozilla.com/fr/firefox/tests/abtest3.html with updated graphics (replacing glow data with the images on the current live pages) *Keep existing template for up-to-date users (ex: https://www.mozilla.com/de/firefox/) Questions? Thanks! ~cb
Summary: [Moz Europe] → [Moz Europe] FX Landing Page Experience
Assignee | ||
Comment 1•13 years ago
|
||
Adjusting the title since it affects all our locales on mozilla.com, not just European ones
Summary: [Moz Europe] FX Landing Page Experience → [l10n] FX Landing Page Experience
Assignee | ||
Comment 4•13 years ago
|
||
all the templating work is done and on trunk/stage/prod but only activated on trunk which has the htaccess necessary changes to activate it. https://www-trunk.stage.mozilla.com/de/firefox/ https://www-trunk.stage.mozilla.com/de/firefox/new https://www-trunk.stage.mozilla.com/de/firefox/fx It works locally but not on trunk because I believe our caching mecanism caches the user agent of our visitors for locales, I haven't been able to find a technical solution today to that despite spending several hours on it and trying several approaches with Anthony. The htaccess code is there on trunk: http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/.htaccess?view=markup&pathrev=94107#l302 lines 302 to 318 I believe http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/.htaccess?view=markup&pathrev=94107#l8 should be rewritten to be a regex matching the locale, otherwite the vary-ua environment variable is empty and we are caught in the caching system. Given that I go on holidays tonight, that I am not very skilled with regex ;) and that this code is very sensitive for our en-US download page as well, I prefer to have webdev (James or Anthony for example) work on it quietly while I am away. Basically, everything will works once this htaccess change will be on production with the caching issue is solved.
Comment 5•13 years ago
|
||
Hey Anthony, a couple of questions for you: - Have you had a chance to look into the regew issue Pascal mentioned yet? - When this is resolved (see? I have no doubt in your ability to fix it!), will anything keep us from pushing this live?
Comment 6•13 years ago
|
||
I haven't worked on this because our infrastructure to test it is not ready yet after the .org merge. This is depending on bug 682398 being resolved.
Depends on: 682398
Updated•13 years ago
|
Target Milestone: 3.8 → 3.9
Updated•13 years ago
|
Target Milestone: 3.9 → 3.10
Comment 8•13 years ago
|
||
I have something to test on www-dev.allimoz.org now.
Whiteboard: r=94066,94067,94916 b=trunk
Comment 9•13 years ago
|
||
So http://www-dev.allizom.org/firefox/ seems to work (code is in prefetch.php). But http://www-dev.allizom.org/{locale}/firefox/ does the good redirect but doesn't send the Vary: User-Agent header.
Updated•13 years ago
|
Whiteboard: r=94066,94067,94916 b=trunk → r=94066,94067,94916,94920 b=trunk
Updated•13 years ago
|
Whiteboard: r=94066,94067,94916,94920 b=trunk → r=94066,94067,94916,94920,94923 b=trunk
Updated•13 years ago
|
Whiteboard: r=94066,94067,94916,94920,94923 b=trunk → r=94066,94067,94916,94920,94923,94929 b=trunk
Comment 10•13 years ago
|
||
So this works locally but not one the test website. So I think I'll need to sit down with IT during the all-hands to find a solution for this. Maybe the Apache version or the modules enabled or disabled explains the difference.
Comment 11•13 years ago
|
||
Thanks for this Anthony. Please keep us posted!
Updated•13 years ago
|
Target Milestone: 3.10 → 3.12
Comment 12•13 years ago
|
||
Hey Anthony - Any updates here?
Comment 13•13 years ago
|
||
I need to sit down with Jake to find out why the Apache on my machine (and Pascal's) is not behaving the same way as the Apache for trunk and stage.
Comment 14•13 years ago
|
||
All of the Vary header stuff I'm finding is done in .htaccess files... possibly you've got something in your VirtualHost config which is getting this to work? If you get a chance, could you send it to me (or attach here)? I'll compare to ours and see what seems different. Thanks!
Target Milestone: 3.12 → 3.10
Comment 15•13 years ago
|
||
Jake: Just sent you my vhost config files.
Severity: normal → critical
Target Milestone: 3.10 → 4.0
Updated•13 years ago
|
Whiteboard: r=94066,94067,94916,94920,94923,94929 b=trunk → r=94066,94067,94916,94920,94923,94929,95581 b=trunk
Comment 16•13 years ago
|
||
Rik and I figured this out! It's an Apache bug... kinda. The current documentation indicates that you can set an environment variable in a RewriteRule like this: [E=varyua,R=301]. That's not actually true until Apache 2.2.16... mrapp-stage04 (www-dev) is RHEL5, meaning it runs Apache 2.2.3. The new bedrock environment (Bug 652292) is RHEL6, but even that is only 2.2.15, so it won't work that way either. In versions older than 2.2.16, RewriteRule will only set an environment variable if it has a value... E=varyua is insufficient and ignored. Presumably the documentation back then reflected this... hard to say. The proper syntax is [E=varyua:1,R=301]. Set the variable 'varyua' *to* something, rather than just 'set' it. You can see the changelog here: http://www.apache.org/dist/httpd/CHANGES_2.2 (skip to the 2.2.16 section for this particular issue).
Reporter | ||
Comment 17•13 years ago
|
||
(In reply to Jake Maul [:jakem] from comment #16) > Rik and I figured this out! > > It's an Apache bug... kinda. The current documentation indicates that you > can set an environment variable in a RewriteRule like this: [E=varyua,R=301]. > > That's not actually true until Apache 2.2.16... mrapp-stage04 (www-dev) is > RHEL5, meaning it runs Apache 2.2.3. The new bedrock environment (Bug > 652292) is RHEL6, but even that is only 2.2.15, so it won't work that way > either. > > In versions older than 2.2.16, RewriteRule will only set an environment > variable if it has a value... E=varyua is insufficient and ignored. > Presumably the documentation back then reflected this... hard to say. > > The proper syntax is [E=varyua:1,R=301]. Set the variable 'varyua' *to* > something, rather than just 'set' it. > > > You can see the changelog here: http://www.apache.org/dist/httpd/CHANGES_2.2 > (skip to the 2.2.16 section for this particular issue). HUUUUZAH! also fun to read about.
Comment 18•13 years ago
|
||
Yeah, that was a fun debugging session :) And so the good commit to fix this is r95589. I'll verify this tomorrow after a good night sleep and push if everything is ok.
Whiteboard: r=94066,94067,94916,94920,94923,94929,95581 b=trunk → r=94066,94067,94916,94920,94923,94929,95581,95589 b=trunk
Comment 19•13 years ago
|
||
(In reply to mcbmoz from comment #17) > (In reply to Jake Maul [:jakem] from comment #16) > HUUUUZAH! also fun to read about. I have rarely read a comment and understood so little ;) Looking forward to get this live. Thanks guys.
Assignee | ||
Comment 20•13 years ago
|
||
Anthony, I am currently focused on my l10n work for the State of Mozilla project + in an l10n-drivers meeting in Berlin today. Could you wait for me to be back to Paris (around 21h00) before launching, I'd like to be there when this is pushed live :) Thanks
Comment 21•13 years ago
|
||
Pascal: 21h on a Friday night? :) I won't be working at that time so that would mean Monday.
Assignee | ||
Comment 22•13 years ago
|
||
everything looks good to me on stage, you can push to production Anthony
Comment 23•13 years ago
|
||
This is pushed to stage with r95747 and r95748. Please test on www.allizom.org.
Comment 24•13 years ago
|
||
Pushed with r95753. Everyone: please test this, it's a tricky change so…
Updated•13 years ago
|
Flags: in-testsuite?
Comment 25•13 years ago
|
||
Thanks guys!
Comment 26•13 years ago
|
||
verified fixed http://www.mozilla.org/en-US/firefox/new/
Updated•12 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Updated•12 years ago
|
Flags: in-testsuite?
Updated•10 years ago
|
Flags: in-testsuite? → in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•