Add link to easily mark attachments obsolete

RESOLVED WONTFIX

Status

()

Bugzilla
Attachments & Requests
--
enhancement
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: jdm, Unassigned)

Tracking

Details

(Reporter)

Description

7 years ago
It's a pain to go to an attachment, click "edit details", click the obsolete checkmark, then submit the changes. It would be a lot nicer to have an inline button or link in the attachments box for each entry that allowed marking it as obsolete.
Lets move this to upstream as it is not really a BMO specific issue and see if anyone has any ideas on how best to implement this type of shortcut.
Assignee: nobody → attach-and-request
Component: Bugzilla Tweaks → Attachments & Requests
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: tweaks → default-qa
Version: Current → unspecified

Comment 2

7 years ago
I disagree. You generally don't want to mark an attachment as obsolete without at least looking at it, which you do from the Details page where the obsolete checkbox is.
(Reporter)

Comment 3

7 years ago
I typically need to mark old versions of patches obsolete when I upload new ones. I hate hate hate the number of clicks involved in this. However, I don't see it as being something that is desired by many bugzilla users, hence my placement in the tweaks addon.
(Reporter)

Comment 4

7 years ago
Note that I upload attachments through a script that automatically marks identially-named existing attachments obsolete. This fails on occasion for reasons that are unimportant, hence why I don't just mark attachments obsolete via the regular upload mechanism.
(In reply to Josh Matthews [:jdm] from comment #4)
> Note that I upload attachments through a script that automatically marks
> identially-named existing attachments obsolete. This fails on occasion for
> reasons that are unimportant, hence why I don't just mark attachments
> obsolete via the regular upload mechanism.

Honestly, sounds like your script should be fixed then. Most people can easily obsolete other attachments via the normal upload mechanism, so I don't really see the value of adding yet more useless UI for doing this.
I am not sure how this would work in Bugzilla Tweaks either as currently the WebService API does not allow for editing of current attachment attributes such as obsolete. Also, created a custom URL and using attachment.cgi will not work as looks for a valid token provided by the attachment details form before committing any changes. Have a custom link from the show_bug.cgi page next to each attachment in the table called "Obsolete" or similar would need to somehow contain a valid token which you can't do on the client side.

So to make this work as a feature of Bugzilla itself, the workings of attachment.cgi would also need to change.

dkl

Comment 7

7 years ago
Wontfix per the discussion above (and as already said, you can already mark older attachments as obsolete when uploading new ones).
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.