680248 - Add-on validator doesn't parse CDATA in XML properly.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P5)

Description

[Mike Kaply [:mkaply]]

I'm getting multiple errors like this in my addon:

Warning: Markup tags cannot be closed before they are opened. Perhaps you were just a little overzealous with forward-slashes?

Warning: Tag "handler" closed before it was opened

It appears the validator has trouble when CDATA is not on it's own line.

For example:

      <handler event="focus"><![CDATA[
        document.getAnonymousElementByAttribute(this, "anonid", "textbox").select();
       ]]>
      </handler>

Or

Warning: Tag "constructor" closed before it was opened
chrome/content/bindings/dtsearchbox.xml
<constructor><![CDATA[
]]></constructor>
<method name="handleSearchCommand">

Comment 1

[Wil Clouser [:clouserw]]

Thanks, this sounds like it might be hard to fix

Comment 2

[Mike Kaply [:mkaply]]

What changed to make this start reporting?

It wasn't before.

This seems like an odd thing for the validator to check for since the add-on probably wouldn't work at al if this was in the XUL.

Were there add-ons being submitted with this problem?

Comment 3

[donaddon]

We are seeing this in an XBL file, and it is the source of about 30 warnings for our extension.  The extension and the XBL both work fine.

Comment 4

[Matt Basta [:basta]]

Could you do a few things? First, could you upload the add-on that you're seeing the issue on? And also, what version of Python are you using?

We take advantage of the HTMLParser class in the standard library. It has been known, however, to have a cluster of bugs regarding its handling of CDATA processing instructions and RCDATA elements. Certain versions of Python might have bugs that other versions don't.

Comment 5

[donaddon]

Sure:

* It's the current version of the stumbleupon addon in the gallery (3.95): https://addons.mozilla.org/firefox/downloads/latest/138/addon-138-latest.xpi?src=addondetail

* I am not running the standalone validator, but instead uploading to AMO and letting it tell me the warnings.

FYI:  I just worked around them all by doing as Michael suggested and putting a CR before the beginning of the CDATA tag and a CR after the end of it.

Comment 6

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/pull/84

Comment 7

[Kumar McMillan [:kumar]]

Merged: https://github.com/mozilla/amo-validator/commit/acb485165c3ab5f76666eac0e5c107725cd1f306

Pushed to AMO: https://github.com/jbalogh/zamboni/commit/0ddab79926f4e76ceea49c1584ff80db3a783b2e

Comment 8

[krupa raj[:krupa]]

I am still seeing this warning for https://addons.mozilla.org/firefox/downloads/latest/138/addon-138-latest.xpi?src=addondetail

See the validation results at https://addons-dev.allizom.org/en-US/developers/upload/2e92b8bd7c614f8f840fb9e55b833eec

I looked at the file and looks okay to me. Am I missing something?

Comment 9

[Wil Clouser [:clouserw]]

I only see 1 warning now, and it's not mentioned above:

------------------------------------------------------------
Parse error: tag closed before opened

Warning: Markup tags cannot be closed before they are opened. Perhaps you were just a little overzealous with forward-slashes?

Warning: Tag "a" closed before it was opened
content/stumbleuponOverlay.js
1
0<u style="color:rgb(21,73,193);">See&nbsp;StumbleUpon&nbsp;friend&
------------------------------------------------------------

Is this the same bug?

Comment 10

[Matt Basta [:basta]]

I can't reproduce this locally with the XPI from comment 8, and I'm not seeing the parse error from comment 9. Please reopen if this issue still exists.