Context menu items like "Open All in Tabs" or "New Folder" work on "Bookmark This Page", "Bookmarks Toolbar", "Unsorted Bookmarks", but affect the bookmarks menu folder

NEW
Unassigned

Status

()

Firefox
Bookmarks & History
7 years ago
7 years ago

People

(Reporter: firefoxqa, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/6.0
Build ID: 20110811165603

Steps to reproduce:

- click Bookmarks button to display bookmarks menu
- right-click on "Unsorted Bookmarks" (normally the last option in the list)
- select "Open All in Tabs"


Actual results:

Firefox will open all bookmarks under Bookmarks menu which don't belong to any folder in separate tabs


Expected results:

Firefox should open all bookmarks under "Unsorted Bookmarks" in separate tabs
Note that this works fine if you:
 - select "Show All Bookmarks"
 - from the Library window, do a right-click on "Unsorted Bookmarks"
 - select "Open All in Tabs"
In that case, Firefox will open the correct bookmarks in separate tabs

Comment 1

7 years ago
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110818 Firefox/9.0a1

This is strange...

When I try to Open All in Tabs from the Bookmarks / Unsorted Bookmarks menu with an old, used profile with a lot of unsorted bookmarks Firefox instead just opens https://addons.mozilla.org/en-US/firefox/extensions/bookmarks/.

When I try to do the the same thing with a new profile, where I just have added some unsorted bookmarks, the Open All in Tabs menu entry is greyed out.

But right clicking in the Library window works fine, as described in comment 0.
(Reporter)

Comment 2

7 years ago
(In reply to Thomas Ahlblom from comment #1)
> Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110818 Firefox/9.0a1
> 
> This is strange...
> 
> When I try to Open All in Tabs from the Bookmarks / Unsorted Bookmarks menu
> with an old, used profile with a lot of unsorted bookmarks Firefox instead
> just opens https://addons.mozilla.org/en-US/firefox/extensions/bookmarks/.
> 
> When I try to do the the same thing with a new profile, where I just have
> added some unsorted bookmarks, the Open All in Tabs menu entry is greyed out.
> 
> But right clicking in the Library window works fine, as described in comment
> 0.

This is the same behaviour that I have: Firefox tries to open the bookmarks that are in the Bookmarks menu, under no folder. In your first profile, you probably only have the "Get Bookmark Add-ons" default bookmark, and all the other bookmarks inside folders, and in your second profile, all bookmarks inside folders (including "Unsorted bookmarks"), and none in no folder.

Comment 3

7 years ago
Last good nightly: 2011-04-30
First bad nightly: 2011-05-01

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7162a399c334&tochange=068d876996c6

It guess this exits ever since the implementation of bug 625325, http://hg.mozilla.org/mozilla-central/rev/4bbc17c443c9.
Blocks: 625325
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 6 Branch → Trunk
(Reporter)

Comment 4

7 years ago
(In reply to Thomas Ahlblom from comment #3)
> Last good nightly: 2011-04-30
> First bad nightly: 2011-05-01
> 
> Pushlog:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=7162a399c334&tochange=068d876996c6
> 
> It guess this exits ever since the implementation of bug 625325,
> http://hg.mozilla.org/mozilla-central/rev/4bbc17c443c9.

Yes I couldn't say when the issue appeared, but more generally, the way Unsorted Bookmarks behaves is not convenient: after you bookmark pages, e.g. for reading later using the star icon (simple click), an easy way to view / delete / sort these bookmarks would be great.

Currently it's not the case because Unsorted Bookmarks actually just is a shortcut to Library. So you need to keep this window opened (or display the bookmark pane) while browsing through your unsorted bookmarks.

So instead of this, I agree with bug 626852 for example: users should be given a choice to have unsorted bookmarks behave just like any other folder (open a sub-menu with the contents), or as it does today (if you have too many unsorted bookmarks for example). There is even an add-on for this (https://addons.mozilla.org/fr/firefox/addon/unsorted-bookmarks-folder-menu/) but... even with it, the "Open All in Tabs" option doesn't work for some reason.
OS: All → Windows 7
Hardware: All → x86_64
Version: Trunk → 6 Branch
(Reporter)

Comment 5

7 years ago
Updated the description for this bug, I just noticed that doing middle-click on the Unsorted Bookmarks folder also doesn't work (no result while it should open all bookmarks in separate tabs)
Summary: Doing right-click, "Open All in Tabs" on "Unsorted Bookmarks" from the bookmarks menu opens bookmarks from Bookmarks menu which don't belong to any folder instead of bookmarks belonging to unsorted bookmarks folder → Right-click, "Open All in Tabs", or middle-click on "Unsorted Bookmarks" from the bookmarks menu doesn't work as expected
(Reporter)

Updated

7 years ago
Summary: Right-click, "Open All in Tabs", or middle-click on "Unsorted Bookmarks" from the bookmarks menu doesn't work as expected → Right-click, "Open All in Tabs", or middle-click on "Unsorted Bookmarks" from the bookmarks menu don't work as expected

Comment 6

7 years ago
Can't reproduce middle-click reliably.

But I noticed that the context menu item "Open All in Tabs" works on "Bookmark This Page", "Bookmarks Toolbar", and "Unsorted Bookmarks", but instead of opening the items in the bookmarks tollbar folder or the unsorted bookmarks folder, it opens bookmarks in the bookmarks menu folder.
The same is true for other items in the context menu, e.g. new folder.

So this is a general problem with the context menu.
No longer blocks: 625325
Summary: Right-click, "Open All in Tabs", or middle-click on "Unsorted Bookmarks" from the bookmarks menu don't work as expected → Context menu items like "Open All in Tabs" or "New Folder" work on "Bookmark This Page", "Bookmarks Toolbar", "Unsorted Bookmarks", but affect the bookmarks menu folder
Version: 6 Branch → Trunk
(Reporter)

Comment 7

7 years ago
(In reply to Steffen Wilberg from comment #6)
> Can't reproduce middle-click reliably.
> 
> But I noticed that the context menu item "Open All in Tabs" works on
> "Bookmark This Page", "Bookmarks Toolbar", and "Unsorted Bookmarks", but
> instead of opening the items in the bookmarks tollbar folder or the unsorted
> bookmarks folder, it opens bookmarks in the bookmarks menu folder.
> The same is true for other items in the context menu, e.g. new folder.
> 
> So this is a general problem with the context menu.

Yes I agree, this description is more accurate.

For the middle-click: if you use it on a normal folder, the expected behaviour is that all bookmarks inside this folder are opened in separate tabs (almost similar to the "Open All in Tabs" option, except that the current tab doesn't get replaced).

For me, middle-clicking on "Unsorted Bookmarks" from the Bookmarks menu consistently doesn't open anything, while it works fine from Library window or bookmarks pane.
This is due to how the menu view handles selection, if it can't select the current node it will consider its parent instead. This happens from a long time, there should already be an old bug describing the same issue with Bookmarks toolbar entry in the bookmarks menu.
Whiteboard: [DUPEME]

Comment 9

7 years ago
Dup of Bug 429469 ?

Comment 10

7 years ago
The basic problems in the current bug and bug 429469 are similar, but the expected results in this bug is "Firefox should open all bookmarks under "Unsorted Bookmarks" in separate tabs". Bug 429469 asks for removal of the context menu.
let's add a dep for now.
Depends on: 429469
Whiteboard: [DUPEME]
You need to log in before you can comment on or make changes to this bug.