680328 - Wrong login credentials should show an error message

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect, P1)

Description

[Tobias (:Tobbi) Markus]

When going to https://mozillians-dev.allizom.org/en-US/login, then specifying wrong login credentials, you just get redirected to the same site. We should display an error message in that case.

Comment 1

[Aakash Desai [:aakashd]]

Agreed, that's just poor UX.

Comment 2

[Aakash Desai [:aakashd]]

We'll need a couple of use cases taken care of here:

* User enters an e-mail address that is not in the database.
* User enters the wrong password, but e-mail address is found in the database.
* User enters an invalid e-mail address that is not in the database.

Comment 3

[tofumatt [:tofumatt]]

The error message should be as generic as possible; otherwise people can find out the email addresses in the database by analyzing the error message provided. But yes, this should happen.

Comment 4

[Austin King [:ozten]]

This is because we subclass the Authentication form improperly (my bad). Grabbing bug.

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/63cc4356a9962d2ad5384f556a1bd2d37edf155c
Show general errors on login for fixes bug#680328

Comment 6

[Austin King [:ozten]]

This was just a template issue.

Comment 7

[Tobias (:Tobbi) Markus]

Verified for both LDAP as well as normal user accounts.