680366 - handleInstallAddonDialog does not call domUtils.nodeCollector with root element

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Remus Pop (:RemusPop)]

Currently in the Addons API we are using
var nodeCollector = new domUtils.nodeCollector(aController.window.document.documentElement);

But .documentElement is not the root node so we receive the following error:
file:///home/remuspop/Desktop/mozmillrepo3/mozmill-tests/lib/dom-utils.js:546\n@:0\n", "message": "The root element has to be specified."

Comment 1

[Remus Pop (:RemusPop)]

Attachment: initial patch

Removed .documentElement in order to call with the right root node.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 554329 [details] [diff] [review]
initial patch

>   // Get the install button
>   // XXX: Bug 671322 
>   //      Using .documentElement until we can support the window object as parameter
>   //      for the nodeCollector constructor
>-  var nodeCollector = new domUtils.nodeCollector(aController.window.document.documentElement);
>+  var nodeCollector = new domUtils.nodeCollector(aController.window.document);

I have fixed bug 671322 a couple of days ago. So we could now even use the window itself as parameter for the constructor. Can you please update the patch and remove the comments which are not necessary anymore? Thanks.

Comment 3

[Remus Pop (:RemusPop)]

Attachment: patch v2

Modified patch as requested.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 554337 [details] [diff] [review]
patch v2

This patch doesn't apply cleanly. Please update your working copy of the repository first. Also please only use r=hskupin for the reviewer part in the commit message.

Comment 5

[Remus Pop (:RemusPop)]

Attachment: patch v3

Modified patch accordingly using a fresh copy of the repository.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/0f5622554f83 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/65e6d1d10c72 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/5b0721f10a89 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/5f4dbefa0622 (release)