Last Comment Bug 680413 - Allow using child process message manager in chrome process
: Allow using child process message manager in chrome process
Product: Core
Classification: Components
Component: IPC (show other bugs)
: unspecified
: All All
: -- major with 1 vote (vote)
: ---
Assigned To: Olli Pettay [:smaug]
: Bill McCloskey (:billm)
Depends on:
Blocks: 516755
  Show dependency treegraph
Reported: 2011-08-19 05:45 PDT by Olli Pettay [:smaug]
Modified: 2011-10-20 04:37 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (16.47 KB, patch)
2011-08-19 05:45 PDT, Olli Pettay [:smaug]
benjamin: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2011-08-19 05:45:50 PDT
Created attachment 554382 [details] [diff] [review]

...this way certain scripts can run also in non-e10s builds, and
in-process-frame-scripts can also use process mm.

Uploaded to try.
Comment 1 Benjamin Smedberg [:bsmedberg] 2011-08-24 09:21:34 PDT
What needs this? I really want to discourage use of the process message manager and I don't want to take this unless the alternative is really messy code in some dependency.
Comment 2 Olli Pettay [:smaug] 2011-08-24 10:39:58 PDT
If any frame mm script uses process mm, it would be hard to use the same code in-process mm.
Comment 3 Olli Pettay [:smaug] 2011-08-24 11:44:05 PDT
So, the patch is about having consistent APIs.
Comment 4 Jez Ng [:int3] 2011-08-26 16:45:33 PDT
Now that Session Restore is using the process message manager to handle data sent on unload, we need this patch to ensure that the same code works both when e10s is enabled and disabled.
Comment 5 Olli Pettay [:smaug] 2011-10-11 04:12:39 PDT
Comment 6 Masatoshi Kimura [:emk] 2011-10-20 04:37:00 PDT
> +  PRBool isChrome = IsChromeProcess();
Should be bool.

Note You need to log in before you can comment on or make changes to this bug.