Allow using child process message manager in chrome process

RESOLVED FIXED

Status

()

Core
IPC
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 554382 [details] [diff] [review]
patch

...this way certain scripts can run also in non-e10s builds, and
in-process-frame-scripts can also use process mm.

Uploaded to try.
(Assignee)

Updated

6 years ago
Attachment #554382 - Flags: review?(benjamin)

Comment 1

6 years ago
What needs this? I really want to discourage use of the process message manager and I don't want to take this unless the alternative is really messy code in some dependency.
(Assignee)

Comment 2

6 years ago
If any frame mm script uses process mm, it would be hard to use the same code in-process mm.
(Assignee)

Comment 3

6 years ago
So, the patch is about having consistent APIs.

Comment 4

6 years ago
Now that Session Restore is using the process message manager to handle data sent on unload, we need this patch to ensure that the same code works both when e10s is enabled and disabled.
Blocks: 516755
Severity: normal → major

Updated

6 years ago
Attachment #554382 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/9a72a10e8bb5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
> +  PRBool isChrome = IsChromeProcess();
Should be bool.
You need to log in before you can comment on or make changes to this bug.