Mozillians search: Don't assume user already searched when going to the search page directly

VERIFIED FIXED

Status

Participation Infrastructure
Phonebook
P2
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Tobbi, Assigned: tofumatt)

Tracking

Details

(Reporter)

Description

6 years ago
When going to https://mozillians-dev.allizom.org/en-US/search you get an error message that the user was not found. Even though the user might have just not entered a search term before. 

We should possibly evaluate the POSTed data or something and just bail out if there has been an error message before.

Simply go to https://mozillians-dev.allizom.org/en-US/search to see the error message.
(Reporter)

Updated

6 years ago
Summary: Allizoms search: Don't assume user already searched when going to the search page directly → Mozillians search: Don't assume user already searched when going to the search page directly
Yeah..cc'ing Crystal here as well.
Agreed. I don't have an opinion on the best way to solve it from a technical perspective. Perhaps they could append a query string that triggers that message if the user truly wasn't found.
(Reporter)

Comment 3

6 years ago
(In reply to Crystal Beasley [:skinny, :crystal] from comment #2)
> Agreed. I don't have an opinion on the best way to solve it from a technical
> perspective. Perhaps they could append a query string that triggers that
> message if the user truly wasn't found.

As I am only a QA intern, I might not have sufficient knowledge in this field, but whenever a query gets POSTed (or some other method), there should be POST data in the header, isn't that right?

Might not checking for POST data when loading the page be a sufficient solution for this? (just my two cents)

Comment 4

6 years ago
(In reply to comment #3)

> As I am only a QA intern,

... and thus... awesome!

Comment 5

6 years ago
STP
1) Go to https://mozillians-dev.allizom.org/en-US/search

Actual:
Search box and feedback "The Mozillian you are looking for is not in the directory. Please check your spelling or invite this person to create a profile."

Expected:
Search box only.
Priority: -- → P2
Target Milestone: --- → 1.0
Assignee: nobody → tofumatt

Comment 6

6 years ago
Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/faf1c38e58e80e3aacaf51a41c0f686981d4cfa0
Don't assume user submitted a search (bug 680469)
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

6 years ago
Verified: https://mozillians.allizom.org/en-US/search asks for a search query and doesn't assume a search was submitted.
Status: RESOLVED → VERIFIED

Updated

6 years ago
Component: mozillians.org → Phonebook
Product: Websites → Community Tools
QA Contact: mozillians-org → phonebook
Target Milestone: 1.0 → ---
Version: unspecified → other
You need to log in before you can comment on or make changes to this bug.