The default bug view has changed. See this FAQ.

missed some code removal in bug 403524

RESOLVED FIXED in mozilla9

Status

()

Core
Layout: Block and Inline
P4
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
I was going through quirks mode checks to update https://developer.mozilla.org/en/Mozilla_Quirks_Mode_Behavior and I noticed a few things that should have been removed when the quirks and standards mode text-decoration code was merged.

I'd be interested in opinions on whether I should ask for aurora approval for these.  My inclination is to do so.
(Assignee)

Comment 1

6 years ago
Created attachment 554483 [details] [diff] [review]
patch 1: remove extra overflow unioning
Attachment #554483 - Flags: review?(roc)
(Assignee)

Comment 2

6 years ago
Created attachment 554485 [details] [diff] [review]
patch 2: remove quirks check around text-decoration checkin nsTextFrame::ComputeTightBounds
Attachment #554485 - Flags: review?(roc)
Comment on attachment 554483 [details] [diff] [review]
patch 1: remove extra overflow unioning

Review of attachment 554483 [details] [diff] [review]:
-----------------------------------------------------------------

I would probably not bother putting this on Aurora, but I don't feel strongly about it.
Attachment #554483 - Flags: review?(roc) → review+
Attachment #554485 - Flags: review?(roc) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d2b61ed8e44
https://hg.mozilla.org/integration/mozilla-inbound/rev/b727463566a1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/1d2b61ed8e44
http://hg.mozilla.org/mozilla-central/rev/b727463566a1
You need to log in before you can comment on or make changes to this bug.