Handle removeAllPages more sanely in tests

RESOLVED FIXED in mozilla9

Status

()

Toolkit
Places
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla9
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 554554 [details] [diff] [review]
patch v1.0

Tests should ensure cleanup is done before proceeding.
I've run all tests locally, but I will push to try before landing.
Attachment #554554 - Flags: review?(dietrich)
(Assignee)

Comment 1

7 years ago
Created attachment 554555 [details] [diff] [review]
patch v1.1

forgot a qref
Assignee: nobody → mak77
Attachment #554554 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #554554 - Flags: review?(dietrich)
Attachment #554555 - Flags: review?(dietrich)

Comment 2

7 years ago
Try run for 0897fbc69a57 is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=0897fbc69a57
Results (out of 101 total builds):
    success: 91
    warnings: 8
    failure: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mak77@bonardo.net-0897fbc69a57
(Assignee)

Comment 3

7 years ago
the failures are unrelated, just a nice collection of random orange (unfortunately) :(
Comment on attachment 554555 [details] [diff] [review]
patch v1.1

Review of attachment 554555 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.
Attachment #554555 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/mozilla-central/rev/1e02b2b0d6a6
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
(Assignee)

Updated

7 years ago
Blocks: 655121
You need to log in before you can comment on or make changes to this bug.