Initial click on named anchor unselects that item in link properties

VERIFIED FIXED in mozilla0.9

Status

()

Core
Editor
P3
normal
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: sujay, Assigned: Charles Manske)

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
using 2/7 build of netscape

1) launch netscape
2) launch composer
3) insert text ("hello world")
4) hit carriage return
5) insert named anchor "foo"
6) highlight "hello world"
7) bring up link props

click on "foo" in named anchor list

it doesn't select the first time.

you have to click on "foo" again to select it.

all platforms.

Comment 1

17 years ago
Sujay and I both saw this one, assigning to cmanske
Assignee: beppe → cmanske
Priority: -- → P3
Target Milestone: --- → mozilla0.9.1
(Assignee)

Comment 2

17 years ago
Created attachment 25071 [details] [diff] [review]
Fix the bug
(Assignee)

Comment 3

17 years ago
Simple fix is ready.
Status: NEW → ASSIGNED
Whiteboard: FIX IN HAND
Target Milestone: mozilla0.9.1 → mozilla0.9

Comment 4

17 years ago
r=brade
Whiteboard: FIX IN HAND → FIX IN HAND; waiting for sr=

Comment 5

17 years ago
sr=sfraser
(Assignee)

Comment 6

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

17 years ago
still not fixed...just tried it on 2/26 build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

17 years ago
This is really a different bug than original, so I change the summary.
Clicking on a named anchor takes the name and appends it to "#" in the Location
(href) input field, but unselects the named anchor in the list, which is
confusing to user. Easy to fix.
Status: REOPENED → ASSIGNED
Summary: two clicks required on anchor in link props to select it → Initial click on named anchor unselects that item in link properties
(Assignee)

Comment 9

17 years ago
Created attachment 26443 [details] [diff] [review]
Fixes focus change from list when clicked on.

Updated

17 years ago
Whiteboard: FIX IN HAND; waiting for sr= → FIX IN HAND; waiting for sr= and r=

Comment 10

17 years ago
Some questions/comments on the 02/28/01 14:00 patch:

1. Avoid double negatives, they can sometimes be confusing:

       if(!dontChange)

   How 'bout changing the var name to gClearListSelections, reversing the init 
value and checking:

      var gClearListSelections = true;
      ...
      if (gClearListSelections)

2. Is there a way to avoid using a global? Like making it so you can do 
something like dialog.clearListSelections? Not a requirement, but I hate 
globals.

3. Fix the indentation of the Unselect calls you are pushing under your new if 
statement.

4. Remove the ChangeText() call that you commented out.
(Assignee)

Comment 11

17 years ago
There's no advantage to not using "global", which are equivalent to
window.gVariable anyway, and scope to just the dialog's window.
Ok about other comments.
(Assignee)

Comment 12

17 years ago
Created attachment 26885 [details] [diff] [review]
Updated fix

Comment 13

17 years ago
r=brade
Whiteboard: FIX IN HAND; waiting for sr= and r= → FIX IN HAND; waiting for sr=
(Assignee)

Comment 14

17 years ago
checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND; waiting for sr=
(Reporter)

Comment 15

17 years ago
verified in 4/19 build.

however there is a new problem in that OK button is not
highlighted after clicking on named anchor in list.

see Bug 76680
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.