Closed Bug 680642 Opened 11 years ago Closed 11 years ago

MacroAssemblerMIPS.h is included but missing

Categories

(Core :: JavaScript Engine, defect)

Other
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9
Tracking Status
firefox7 --- affected
firefox8 --- affected

People

(Reporter: glandium, Unassigned)

Details

Attachments

(1 file)

This is the build error I get when building 7.0 beta 1 on mips:
../../../js/src/assembler/assembler/MacroAssembler.h:46:32: fatal error: MacroAssemblerMIPS.h: No such file or directory

It looks like the upstream assembler was not imported fully. However, that include was already there before, and it didn't fail to build, so in fact, I guess this may well be another manifestation of bug 670719.
It's actually not related to bug 670719.

The root problem is that js/src/assembler/wtf/Platform.h does a bunch of autodetections that override what is defined in js/src/Makefile.in, such as enabling jit on mips... and the jit file for mips is missing.
For reference, this was caused by bug 625600
This is the easy fix. The more elaborate fix would be to import the missing file from the webkit source.
Attachment #554746 - Flags: review?(dmandelin)
Attachment #554746 - Flags: review?(dmandelin) → review+
http://hg.mozilla.org/mozilla-central/rev/43669eae1968
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.