Closed Bug 680678 Opened 13 years ago Closed 13 years ago

Sync: byteArrayToString appears more than once in util.js

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [qa-][fixed in services])

Attachments

(1 file)

Oops.
Attached patch Minimal fix. v1Splinter Review
Two identical copies of the same method, 300 lines apart. *sigh*

According to hg annotate, I checked in one copy in, ahem, "simplified crypto". philikon checked in an identical version two changesets later. Parallel working, ho!

E_SAME_BRAIN.

Tests pass, strict mode error no longer arises.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #554643 - Flags: review?(philipp)
Caused by:

JS Component Loader: ERROR resource://services-sync/resource.js:412
                     SyntaxError: redefining delete is deprecated

?
(In reply to Richard Newman [:rnewman] from comment #2)
> Caused by:
> 
> JS Component Loader: ERROR resource://services-sync/resource.js:412
>                      SyntaxError: redefining delete is deprecated
> 
> ?

Crap, wrong bug window. Ignore.
Whiteboard: [qa-]
Comment on attachment 554643 [details] [diff] [review]
Minimal fix. v1

no brainer
Attachment #554643 - Flags: review?(philipp) → review+
Fixed in services:

 http://hg.mozilla.org/services/services-central/rev/2e842de9564d
Whiteboard: [qa-] → [qa-][fixed in services]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: