680737 - Use the review date instead of the creation date for revision flags in Helpfulness Vote charts

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Scoobidiver (away)]

What is important in revision flags is when the revision comes live, not when it was created, so use the review date instead of the creation date for revision flags in Helpfulness Vote charts.

See:
https://support.mozilla.com/en-US/kb/what-are-app-tabs/history where the July 4 revision has been approved on July, 12.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I think the issue was that all the original revisions migrated from tiki don't have a reviewed date. I am pretty sure they do have a created date, so we can just fallback to that when there is no reviewed date.

Comment 2

[Tanay Gavankar [:tgavankar]]

I believe that having the flags represent the created date was originally a conscious design decision. The "Revision" column in the table is listed with the date created (rather than date reviewed), and the purpose of the flags was to be able to link votes back to which specific revision they applied to (especially while bug 679882 is still open). This would not be clear if the flags were placed on reviewed dates but were labeled with creation dates of revisions.

However, I completely agree that the flags should refer to review dates (or fall back to created dates if they're not defined). Because of the hover-highlight functionality (hovering over the graph highlights the appropriate revision), I feel comfortable with updating the flag positions to indicate reviewed date. Hopefully, users won't get confused when the dates of the flags and the corresponding highlighted revision dates don't match up.

Comment 3

[Tanay Gavankar [:tgavankar]]

Done in https://github.com/jsocol/kitsune/commit/0ed5b60.

Comment 4

[Rebecca Billings [:rbillings]]

Verified helpfulness votes show revision approval date