680806 - tearing when assigning new values to img.src

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Stefan]

User Agent:  

Steps to reproduce:

Assign new value to img's src attribute.


Actual results:

Tearing (http://en.wikipedia.org/wiki/Screen_tearing)


Expected results:

No tearing.

Comment 1

[Stefan]

The first bad revision is:
changeset: 73135:fa82e3fa46b9
user: Justin Lebar <[e-mail]>
date: Wed Jul 20 18:05:46 2011 -0400
summary: Bug 666352 - Back out image decode timing changes from bug 590260 to make the browser more responsive while decoding images. r=joe

Fx 3.6.20 is OK, google also.

Testcase is in preparation.

Comment 2

[Stefan]

Testcase: http://www.vogtner.de/mozilla/680806/

Click thru all 4 different images (actually it's the same images stored four times with different filenames). After the browser cache is saturated the tear happens near the upper button edge.

Comment 3

[Stefan]

Applying the changeset fa82e3fa46b9 reversed to the a more recent revision (e.g. current) does not ban the tearing but shift it downwards.

Comment 4

[Stefan]

Reproduced on nightly 2011-08-21 win64

Comment 5

[Justin Lebar (not reading bugmail)]

To make sure I understand, bug 666352 (changeset fa82e3fa46b9) affected where the tearing was occurring, but didn't make the problem worse?

I'm no expert, but I think bug 674549 should fix this?  That one is currently blocked on dependent work.

Comment 6

[Joe Drew (not getting mail)]

(In reply to Justin Lebar [:jlebar] from comment #5)
> I'm no expert, but I think bug 674549 should fix this?  That one is
> currently blocked on dependent work.

Probably, though if the graphics card's in the middle of an update when the LCD refreshes, we can still get tearing.

Comment 7

[[:Aleksej]]

Cannot reproduce with 7.0b2(c1) 20110824172139 Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20100101 Firefox/7.0 (no hardware acceleration).

Comment 8

[Stefan]

(In reply to Justin Lebar [:jlebar] from comment #5)
> To make sure I understand, bug 666352 (changeset fa82e3fa46b9) affected
> where the tearing was occurring, but didn't make the problem worse?

I must withdraw my comment #3. Actually when I'm using 

    image.mem.max_ms_before_yield;400
    image.mem.decode_bytes_at_a_time;200000

there is no flicker/tearing.

BTW: Has anybody noticed that JPEGs do not get rendered progressively after their URL is assigned to src? Except for the first assignment. Is that intentional?

Comment 9

[Stefan]

oops.

Comment 10

[Stefan]

Firefox ESR 17.0.7: Problem persists.
Firefox 28: OK.