Closed Bug 680831 Opened 13 years ago Closed 13 years ago

app ready event is sent to wrong panel

Categories

(Mozilla Labs :: OpenWebApps, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: markh, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

If you open a tab, invoke the app panel, then open a second tab and invoke the panel for the same service used in the first tab, the "app_ready" event for apps in the second panel is delivered to the first panel. This is due to a problem in how services.js locates the correct panel - it just matches the panel URL, but in the example above, both panels have the same URL. A fix is to give each panel an "invocation id" then use that ID to match the app ready window with the correct panel.
Pointer to Github pull-request
Attachment #554792 - Flags: review?(anant)
Attachment #554791 - Attachment is obsolete: true
Comment on attachment 554792 [details] Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/81# Not a big fan of counters, we should just key the popup panels on the current tab's URI (as opposed to the panel URI) and open a new one if one hasn't been created. This way, we can re-use the same panel if I open the same web page in two different tabs (and use the same service) which is I think is desirable. Thoughts?
Attachment #554792 - Flags: review?(anant)
Attachment #554792 - Flags: review-
Attachment #554792 - Flags: feedback?(mixedpuppy)
(In reply to Anant Narayanan [:anant] from comment #3) > Comment on attachment 554792 [details] > Pointer to Github pull request: > https://github.com/mozilla/openwebapps/pull/81# > > Not a big fan of counters, we should just key the popup panels on the > current tab's URI (as opposed to the panel URI) and open a new one if one > hasn't been created. This way, we can re-use the same panel if I open the > same web page in two different tabs (and use the same service) which is I > think is desirable. > > Thoughts? It's a temporary solution that works right now. As I mentioned in IRC, we'll have to do away with the way we use contentWindow, it wont be e10s compatible.
Comment on attachment 554792 [details] Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/81# Per IRC dicussion, fine temporary solution for now, we must revisit this later though.
Attachment #554792 - Flags: review-
Attachment #554792 - Flags: review+
Attachment #554792 - Flags: feedback?(mixedpuppy)
Fixed in 309f273b7d1906c2815f8ff5cc67f702c60c4282 and pointer to this bug added to bug 681155.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: