680848 - Add MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags when linking static libraries

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The new fakelibs support removed the use of the MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags, but there are some cases where we do pass the .a file to the linker, in which case the behaviour is not the same as passing the individual .o files. Wrapping the remaining .a files on the command line with MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL would solve this.
While this is not strictly necessary, it makes things easier for bug 680440.

Incidentally, doing so would fix builds with NO_EXPAND_LIBS=1, which currently fail linking libxul.so because of the lack of MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags when linking static libraries

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 554802 [details] [diff] [review]
Add MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL flags when linking static libraries

This breaks tracemalloc builds.

Comment 3

[Mike Hommey [:glandium]]

MKSHLIB_FORCE_ALL/MKSHLIB_UNFORCE_ALL were removed in bug 1188555.