TestDllInterceptor.cpp fails to compile on mingw

RESOLVED FIXED in mozilla9

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 554818 [details] [diff] [review]
fix v1.0

__inout is not defined on mingw because it conflicts with GCC-provided headers. Also the test uses wmain, which is tricky to get right on mingw. Since tests don't use main arguments anyway, I've just changed it to regular main.
Attachment #554818 - Flags: review?(mh+mozilla)
Attachment #554818 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 1

6 years ago
Thanks for the quick review!

http://hg.mozilla.org/integration/mozilla-inbound/rev/98f26632de7f
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/98f26632de7f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.