Last Comment Bug 680865 - TestDllInterceptor.cpp fails to compile on mingw
: TestDllInterceptor.cpp fails to compile on mingw
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla9
Assigned To: Jacek Caban
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2011-08-22 04:26 PDT by Jacek Caban
Modified: 2011-08-22 10:56 PDT (History)
1 user (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (1.48 KB, patch)
2011-08-22 04:26 PDT, Jacek Caban
mh+mozilla: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2011-08-22 04:26:50 PDT
Created attachment 554818 [details] [diff] [review]
fix v1.0

__inout is not defined on mingw because it conflicts with GCC-provided headers. Also the test uses wmain, which is tricky to get right on mingw. Since tests don't use main arguments anyway, I've just changed it to regular main.
Comment 1 User image Jacek Caban 2011-08-22 05:25:26 PDT
Thanks for the quick review!
Comment 2 User image Mounir Lamouri (:mounir) 2011-08-22 10:55:44 PDT

Note You need to log in before you can comment on or make changes to this bug.