Closed Bug 680865 Opened 8 years ago Closed 8 years ago

TestDllInterceptor.cpp fails to compile on mingw

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
__inout is not defined on mingw because it conflicts with GCC-provided headers. Also the test uses wmain, which is tricky to get right on mingw. Since tests don't use main arguments anyway, I've just changed it to regular main.
Attachment #554818 - Flags: review?(mh+mozilla)
Attachment #554818 - Flags: review?(mh+mozilla) → review+
Thanks for the quick review!

http://hg.mozilla.org/integration/mozilla-inbound/rev/98f26632de7f
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/98f26632de7f
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.