The default bug view has changed. See this FAQ.

nsFilePicker.h fails to compile on mingw

RESOLVED FIXED in mozilla9

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

742 bytes, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Created attachment 554819 [details] [diff] [review]
fix v1.0

GCC (correctly) doesn't like the syntax used there:

mozilla-central/widget/src/windows/nsFilePicker.h:109:15: error: extra qualification 'AutoRestoreWorkingPath::' on member 'HasWorkingPath' [-fpermissive]
Attachment #554819 - Flags: review?(neil)

Comment 1

6 years ago
Comment on attachment 554819 [details] [diff] [review]
fix v1.0

Indeed. Sorry for overlooking that.
Attachment #554819 - Flags: review?(neil) → review+
Oops sorry about that.  Cut and paste error.
(Assignee)

Comment 3

6 years ago
Thanks for the quick review!

http://hg.mozilla.org/integration/mozilla-inbound/rev/7b7109b4bfb7
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/7b7109b4bfb7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.