Last Comment Bug 680866 - nsFilePicker.h fails to compile on mingw
: nsFilePicker.h fails to compile on mingw
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla9
Assigned To: Jacek Caban
: Jim Mathies [:jimm]
Depends on:
  Show dependency treegraph
Reported: 2011-08-22 04:33 PDT by Jacek Caban
Modified: 2011-08-22 10:55 PDT (History)
2 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (742 bytes, patch)
2011-08-22 04:33 PDT, Jacek Caban
neil: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2011-08-22 04:33:18 PDT
Created attachment 554819 [details] [diff] [review]
fix v1.0

GCC (correctly) doesn't like the syntax used there:

mozilla-central/widget/src/windows/nsFilePicker.h:109:15: error: extra qualification 'AutoRestoreWorkingPath::' on member 'HasWorkingPath' [-fpermissive]
Comment 1 User image 2011-08-22 04:38:26 PDT
Comment on attachment 554819 [details] [diff] [review]
fix v1.0

Indeed. Sorry for overlooking that.
Comment 2 User image Brian R. Bondy [:bbondy] 2011-08-22 05:07:54 PDT
Oops sorry about that.  Cut and paste error.
Comment 3 User image Jacek Caban 2011-08-22 05:25:48 PDT
Thanks for the quick review!
Comment 4 User image Mounir Lamouri (:mounir) 2011-08-22 10:55:24 PDT

Note You need to log in before you can comment on or make changes to this bug.