Last Comment Bug 680868 - pldhash.cpp fails to compile on mingw-w64
: pldhash.cpp fails to compile on mingw-w64
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86_64 Windows 7
-- normal (vote)
: mozilla9
Assigned To: Jacek Caban
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2011-08-22 04:46 PDT by Jacek Caban
Modified: 2011-09-10 08:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (840 bytes, patch)
2011-08-22 04:46 PDT, Jacek Caban
benjamin: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2011-08-22 04:46:38 PDT
Created attachment 554820 [details] [diff] [review]
fix v1.0

There is void* to unsigned long cast that is losing precision on win64 (because long is 32-bits). It's an error by default in GCC. The code already does two-step casting (for other 64-bit platforms that have 64-bit long), so just using proper type is enough for the fix.
Comment 1 User image Mike Hommey [:glandium] 2011-08-22 04:56:21 PDT
Comment on attachment 554820 [details] [diff] [review]
fix v1.0

Review of attachment 554820 [details] [diff] [review]:

I don't know if we want to add a use of a NSPR type. Note that in bug 569821, the same was done to jsdhash.cpp, using uintptr_t.
Comment 2 User image Jacek Caban 2011-08-22 05:30:10 PDT
Thanks for the review. pldhash.cpp is already full of NSPR types, so it seems a good choice for me. I can change it if desired.
Comment 4 User image Justin Wood (:Callek) [away until Feb 27] 2011-09-09 22:50:23 PDT
(In reply to Jacek Caban from comment #3)

landed on m-c

Note You need to log in before you can comment on or make changes to this bug.