Closed Bug 680897 Opened 10 years ago Closed 10 years ago
There should be a colon after "You have chosen to open" in download window
Very, very tiny thing that annoys me, there should probably be a colon to match the rest of the info lines, and grammatically (at least from what I'm told) would be best if it were.
Attachment #554856 - Flags: review?(sdwilsh)
Hmm, I think we need to change the entity name here too (which makes the patch a bit more complicated).
gavin - do we need to change the entity name in this case?
Yes - better to err on the side of changing rather than not changing, and there's only use use of this string in this case.
Attachment #554856 - Flags: review?(sdwilsh) → review-
Attachment #630019 - Flags: review? → review?(fryn)
Comment on attachment 630019 [details] [diff] [review] Changed entity name You need to update the code that uses &intro.label;
Component: General → Download Manager
Product: Firefox → Toolkit
QA Contact: general → download.manager
Updated entity name
Comment on attachment 630029 [details] [diff] [review] Patch I think you forgot to make the string change :)
d'oh. Good now?
Comment on attachment 640438 [details] [diff] [review] Patch v4 Yes, thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2888cfe516c Try push: https://tbpl.mozilla.org/?tree=Try&rev=541189b99439
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.