Closed Bug 680897 Opened 10 years ago Closed 10 years ago

There should be a colon after "You have chosen to open" in download window

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: tanner, Assigned: cleer)

Details

Attachments

(1 file, 3 obsolete files)

Attached patch Patch (obsolete) — Splinter Review
Very, very tiny thing that annoys me, there should probably be a colon to match the rest of the info lines, and grammatically (at least from what I'm told) would be best if it were.
Attachment #554856 - Flags: review?(sdwilsh)
Hmm, I think we need to change the entity name here too (which makes the patch a bit more complicated).
gavin - do we need to change the entity name in this case?
Yes - better to err on the side of changing rather than not changing, and there's only use use of this string in this case.
Attachment #554856 - Flags: review?(sdwilsh) → review-
Assignee: tanner.sumo.bugs → nobody
Attached patch Changed entity name (obsolete) — Splinter Review
Attachment #630019 - Flags: review?
Attachment #630019 - Flags: review? → review?(fryn)
Comment on attachment 630019 [details] [diff] [review]
Changed entity name

You need to update the code that uses &intro.label;
Attachment #630019 - Attachment is patch: true
Attachment #630019 - Flags: review?(fryn) → review-
Component: General → Download Manager
Product: Firefox → Toolkit
QA Contact: general → download.manager
Attached patch Patch (obsolete) — Splinter Review
Updated entity name
Attachment #554856 - Attachment is obsolete: true
Attachment #630019 - Attachment is obsolete: true
Assignee: nobody → chlee
Attachment #630029 - Flags: review?
Comment on attachment 630029 [details] [diff] [review]
Patch

I think you forgot to make the string change :)
Attachment #630029 - Attachment is patch: true
Attachment #630029 - Flags: review? → review-
Attached patch Patch v4Splinter Review
d'oh. Good now?
Attachment #630029 - Attachment is obsolete: true
Attachment #640438 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 640438 [details] [diff] [review]
Patch v4

Yes, thanks.
Attachment #640438 - Attachment is patch: true
Attachment #640438 - Flags: review?(mnoorenberghe+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/e2888cfe516c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.