Closed
Bug 681017
Opened 13 years ago
Closed 13 years ago
A search for the string "library" lists/shows 5 in the Combined view, but the full 7 in the Library view
Categories
(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)
addons.mozilla.org Graveyard
Add-on Builder
Tracking
(Not tracked)
VERIFIED
FIXED
Builder 0.9.10
People
(Reporter: stephend, Assigned: smcarthur)
References
()
Details
Attachments
(5 files, 1 obsolete file)
When I search for "Library" on staging (https://builder-addons.allizom.org/search/?q=library&type=l), I get 5 libraries listed when I slect the "Combined", view filter, but the full 7 appear when I select "Libraries".
Reporter | ||
Comment 1•13 years ago
|
||
Reporter | ||
Updated•13 years ago
|
Flags: in-testsuite?
Assignee | ||
Comment 2•13 years ago
|
||
The combined screen is correctly only showing a max of 5 per type. Perhaps the UI needs to express 5 of #? Or a link underneath to "View all # libraries"?
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Sean McArthur [:seanmonstar] from comment #2)
> The combined screen is correctly only showing a max of 5 per type. Perhaps
> the UI needs to express 5 of #? Or a link underneath to "View all #
> libraries"?
Yeah, either works; Dan, your thoughts?
Comment 4•13 years ago
|
||
Yes we should be showing an "out of X" indication. But a bigger question: If there are more results than 5 in the Library category in Stephen's screenshot, where is my link to jump to see more or a paging UI to get there?
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → smcarthur
Priority: -- → P2
Assignee | ||
Comment 5•13 years ago
|
||
The link underneath has been added to the Combined page on master.
https://github.com/mozilla/FlightDeck/commit/c7fe3bde58403a3d561902a2df70dd088bedbace
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•13 years ago
|
||
Reporter | ||
Comment 7•13 years ago
|
||
Reporter | ||
Comment 8•13 years ago
|
||
Looks like some intended behavior is there, such as:
* letting a few more results in, where they'll fit on the page, for some queries
* adding in a "See all 9 matching add-ons ->" link for other cases
However, as Dan pointed out, https://builder-addons.allizom.org/search/?type=a&author=4 still doesn't conveniently link you to the rest of the 183 add-ons results for that query.
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 9•13 years ago
|
||
Reporter | ||
Updated•13 years ago
|
Attachment #556951 -
Attachment is obsolete: true
Reporter | ||
Comment 10•13 years ago
|
||
Comment 11•13 years ago
|
||
The link Stephen included in his last comment shows a slightly different bug than the comment describes. The By Me filter is selected in that query, this means that *only* 6 results should be shown, not 183. It is like if you selected "Only laptops that have 15 inch screens and greater" on Amazon, and then adding the filter "Only laptops that have solid state drives". You would not show all 200 15 inch screen laptops, you would show the 10 that *also* possessed SSDs, does this make sense?
I would love to see this in tomorrow's release.Iit is pretty confusing trying to understand the connection between what was searched for, and the results that are displayed.
Assignee | ||
Comment 12•13 years ago
|
||
If I understand everything that you guys said, then this works, it's just showing the wrong number in the link. This is because the number in the link is the same variable as the number shown in the sidebar, which is filed in bug 681080.
When those values are correctly including all the filters, the numbers in these links should be correct as well.
Depends on: 681080
Assignee | ||
Comment 13•13 years ago
|
||
with bug 681080 being fixed, this is fixed also.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 14•13 years ago
|
||
While testing this, I discovered bug 683380.
Reporter | ||
Comment 15•13 years ago
|
||
Verified FIXED; will, of course, work with Daniel to verify bug 681080 separately, too.
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•