Closed Bug 681203 Opened 11 years ago Closed 11 years ago

Fallback to bind all symbols when dynamic symbol lookup is not supported

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Platform:
x86
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Bind all symbols when dynamic symbol lookup is not supported
2.66 KB, patch
mwu
: review+
Details | Diff | Splinter Review 
Dynamic symbol lookup in our android linker (currently) only works on ARM. More than that, it will fail to build on other architectures. We should fall back on non dynamic symbol lookup code when dynamic symbol lookup is not implemented.
This effectively restores the old code when no runtime_reloc function is defined. This will avoid failing to build on x86 android.
Attachment #555050 - Flags: review?(mwu)
Attachment #555050 - Flags: review?(mwu) → review+
http://hg.mozilla.org/mozilla-central/rev/93e859044536
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.