Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fallback to bind all symbols when dynamic symbol lookup is not supported

RESOLVED FIXED in mozilla9

Status

()

Product:
Core
Component:
Widget: Android
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Version:
Trunk
Target:
mozilla9
x86
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Bind all symbols when dynamic symbol lookup is not supported
2.66 KB, patch
mwu
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Dynamic symbol lookup in our android linker (currently) only works on ARM. More than that, it will fail to build on other architectures. We should fall back on non dynamic symbol lookup code when dynamic symbol lookup is not implemented.
(Assignee)

Comment 1

•
6 years ago 
Created attachment 555050 [details] [diff] [review]
Bind all symbols when dynamic symbol lookup is not supported

This effectively restores the old code when no runtime_reloc function is defined. This will avoid failing to build on x86 android.
Attachment #555050 - Flags: review?(mwu)

Updated

•
6 years ago
Attachment #555050 - Flags: review?(mwu) → review+
 (Assignee)

Comment 2

•
6 years ago 
http://hg.mozilla.org/integration/mozilla-inbound/rev/93e859044536
Whiteboard: [inbound]

Comment 3

•
6 years ago 
http://hg.mozilla.org/mozilla-central/rev/93e859044536
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.