Last Comment Bug 681203 - Fallback to bind all symbols when dynamic symbol lookup is not supported
: Fallback to bind all symbols when dynamic symbol lookup is not supported
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: Trunk
: x86 Android
: -- normal (vote)
: mozilla9
Assigned To: Mike Hommey [:glandium]
:
:
Mentors:
Depends on:
Blocks: 651889 681202
  Show dependency tree / graph
 
Reported: 2011-08-23 01:05 PDT by Mike Hommey [:glandium]
Modified: 2011-08-24 01:30 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
Bind all symbols when dynamic symbol lookup is not supported (2.66 KB, patch)
2011-08-23 01:13 PDT, Mike Hommey [:glandium] 		mwu.code: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Mike Hommey [:glandium] 2011-08-23 01:05:01 PDT 
Dynamic symbol lookup in our android linker (currently) only works on ARM. More than that, it will fail to build on other architectures. We should fall back on non dynamic symbol lookup code when dynamic symbol lookup is not implemented.
Comment 1 Mike Hommey [:glandium] 2011-08-23 01:13:17 PDT 
Created attachment 555050 [details] [diff] [review]
Bind all symbols when dynamic symbol lookup is not supported

This effectively restores the old code when no runtime_reloc function is defined. This will avoid failing to build on x86 android.
Comment 3 Marco Bonardo [::mak] 2011-08-24 01:30:52 PDT 
http://hg.mozilla.org/mozilla-central/rev/93e859044536
Note You need to log in before you can comment on or make changes to this bug.