681376 - ewait sporadicly does not work (i.e. does not wait long enough) in mozmill tests

Status: RESOLVED INVALID

(Thunderbird :: Testing Infrastructure, defect)

Description

[Joachim Herb]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0) Gecko/20100101 Firefox/7.0
Build ID: 20110816154714

Steps to reproduce:

This is a follow up bug of bug 519956 comment 182:
In a mozmill test I use mc.ewait("donebutton") to wait for the header pane toolbar customization dialog to show up, if the preference toolbar.customization.usesheet is set to true. 


Actual results:

This does not seem to work sporadically. The following code, which tries to access some elements of the dialog, fails because the dialog has not shown up in time. Adding controller.sleep(1000) seems to fix the problem.

Here are tryserver builds which demonstrate the failure:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=09b83d0ed67e


Expected results:

The mozmill test should wait until the specified element has shown up and proceed then.

Comment 1

[Joachim Herb]

Attachment: Mozmill tests for tryserver runs.

This is the patch for the tryserver builds. There the MAC OSX (non 64) version failed. But sometimes it also fails on my local machine using Windows 7 64bit, 32bit build of Thunderbird.

Comment 2

[:aceman]

You need to request review for the patch from somebody responsible for this component. See https://wiki.mozilla.org/Modules/Thunderbird .

Comment 3

[Joachim Herb]

(In reply to aceman from comment #2)
> You need to request review for the patch from somebody responsible for this
> component. See https://wiki.mozilla.org/Modules/Thunderbird .

The patch only demonstrates the problem. It is not a fix. So I guess it does not make sense to ask for review, does it? Unfortunately I have no idea how to fix this problem.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Let me ask, what is ewait()?

Comment 5

[Joachim Herb]

ewait is defined here:
http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-window-helpers.js#838
It is just a wrapper for waitForElement:
http://mxr.mozilla.org/comm-central/source/mail/test/resources/mozmill/mozmill/extension/resource/modules/controller.js#661

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

You should wait for the sheet window first. Then you probably should also use it's frame document instead of the main window document.

Do you have a change to simplify this testcase even more, so it can be run without any external lib specifically for Thunderbird? I would like to test it in Firefox which should behave the same way.

Comment 7

[Joachim Herb]

Attachment: New test with drag and drop test case

This testcases includes drag and drop because the original test case did non fail any more on the try server:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=7d3d8a2639df
But if ewait is used in drag'n'drop tests for the customization dialog test (and no additional sleep), it fails again:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=0812c861e7fe
(see the Mac mozmill tests).

The attached patch sometimes fails on my local Windows machine.

Comment 8

[Joachim Herb]

Attachment: Firefox mozmill test doing the same as the thunderbird test case

This is a patch against the mozmill firefox test cases repository.

It does the same as the thunderbird test case: Open customization dialog using sheet and add/removes one button each.

It works on my local machine (without additional sleep).

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joachim Herb from comment #8)
> This is a patch against the mozmill firefox test cases repository.
> 
> It works on my local machine (without additional sleep).

So you are saying that this reported issue only manifests in Thunderbird and cannot be reproduced in Firefox?

Comment 10

[Joachim Herb]

(In reply to Henrik Skupin (:whimboo) from comment #9)
> (In reply to Joachim Herb from comment #8)
> > This is a patch against the mozmill firefox test cases repository.
> > 
> > It works on my local machine (without additional sleep).
> 
> So you are saying that this reported issue only manifests in Thunderbird and
> cannot be reproduced in Firefox?
Using Windows I cannot reporduce the problem with firefox. But using Linux I can *sometimes* reproduce it with firefox.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joachim Herb from comment #10)
> Using Windows I cannot reporduce the problem with firefox. But using Linux I
> can *sometimes* reproduce it with firefox.

But it's always reproducible on Windows with Thunderbird? So what's the exact failure you get on Linux with Firefox and in which line of the code? I can't reproduce it myself on OS X.

Comment 12

[Joachim Herb]

This is really sporadic:
Today I cannot reproduce it with Windows (neither with Thunderbird nor Firefox). But with Linux (in a virtual box) the (above) Firefox test case fails in the first and second run:
failed to create drawable
DEBUG | mozmill.startRunner | true
DEBUG | mozmill.setModule | "currentModule"
DEBUG | mozmill.setState | "currentState"
DEBUG | mozmill.setTest | {"name": "setupModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js"}
DEBUG | mozmill.log | {"message": "Use controller.mainMenu instead.", "property": "controller.menus - DEPRECATED"}
INFO | Step Pass: {"function": "controller.click()"}
INFO | Step Pass: {"function": "controller.waitForEval()"}
INFO | Step Pass: {"function": "Controller.open()"}
INFO | Step Pass: {"function": "controller.waitFor()"}
INFO | Step Pass: {"function": "controller.waitForPageLoad()"}
DEBUG | mozmill.endTest | {"passes": [{"function": "controller.click()"}, {"function": "controller.waitForEval()"}, {"function": "Controller.open()"}, {"function": "controller.waitFor()"}, {"function": "controller.waitForPageLoad()"}], "fails": [], "name": "testCustomization.js::setupModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js", "failed": 0, "passed": 5}
DEBUG | mozmill.setState | "currentState"
DEBUG | mozmill.setTest | {"name": "testOpenCustomization", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js"}
INFO | Step Pass: {"function": "controller.click()"}
INFO | Step Pass: {"function": "controller.waitFor()"}
INFO | Step Pass: {"function": "Controller.waitForElement()"}
ERROR | Test Failure: {"exception": {"stack": "synthesizeMouse(null,5,5,[object Object],[object Proxy])@resource://mozmill/stdlib/EventUtils.js:236\nsynthesize_drag_start([object Proxy],null,[object XULElement])@resource://mozmill/modules/frame.js -> file:///home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js:167\ndrag_n_drop_element(null,[object Proxy],[object XULElement],[object Proxy],0.5,0.5,[object XULElement])@resource://mozmill/modules/frame.js -> file:///home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js:128\ntestOpenCustomization()@resource://mozmill/modules/frame.js -> file:///home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js:79\n(testOpenCustomization)@resource://mozmill/modules/frame.js:557\n([object Object])@resource://mozmill/modules/frame.js:626\n([object Object])@resource://mozmill/modules/frame.js:669\n(\"/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js\")@resource://mozmill/modules/frame.js:506\n(\"/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js\")@resource://mozmill/modules/frame.js:681\n((function (filename, invokedFromIDE) {var runner = new Runner(new Collector, invokedFromIDE);runner.runTestFile(filename);runner.end();return true;}),[object Proxy])@resource://jsbridge/modules/server.js:179\n(\"e17033c4-3b0b-11e1-bd48-080027ac35d3\",(function (filename, invokedFromIDE) {var runner = new Runner(new Collector, invokedFromIDE);runner.runTestFile(filename);runner.end();return true;}),[object Proxy])@resource://jsbridge/modules/server.js:183\n", "message": "aTarget is null", "fileName": "resource://mozmill/stdlib/EventUtils.js", "name": "TypeError", "lineNumber": 236}}
DEBUG | mozmill.endTest | {"passes": [{"function": "controller.click()"}, {"function": "controller.waitFor()"}, {"function": "Controller.waitForElement()"}], "fails": [{"exception": {"stack": "synthesizeMouse(null,5,5,[object Object],[object Proxy])@resource://mozmill/stdlib/EventUtils.js:236\nsynthesize_drag_start([object Proxy],null,[object XULElement])@resource://mozmill/modules/frame.js -> file:///home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js:167\ndrag_n_drop_element(null,[object Proxy],[object XULElement],[object Proxy],0.5,0.5,[object XULElement])@resource://mozmill/modules/frame.js -> file:///home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js:128\ntestOpenCustomization()@resource://mozmill/modules/frame.js -> file:///home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js:79\n(testOpenCustomization)@resource://mozmill/modules/frame.js:557\n([object Object])@resource://mozmill/modules/frame.js:626\n([object Object])@resource://mozmill/modules/frame.js:669\n(\"/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js\")@resource://mozmill/modules/frame.js:506\n(\"/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js\")@resource://mozmill/modules/frame.js:681\n((function (filename, invokedFromIDE) {var runner = new Runner(new Collector, invokedFromIDE);runner.runTestFile(filename);runner.end();return true;}),[object Proxy])@resource://jsbridge/modules/server.js:179\n(\"e17033c4-3b0b-11e1-bd48-080027ac35d3\",(function (filename, invokedFromIDE) {var runner = new Runner(new Collector, invokedFromIDE);runner.runTestFile(filename);runner.end();return true;}),[object Proxy])@resource://jsbridge/modules/server.js:183\n", "message": "aTarget is null", "fileName": "resource://mozmill/stdlib/EventUtils.js", "name": "TypeError", "lineNumber": 236}}], "name": "testCustomization.js::testOpenCustomization", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js", "failed": 1, "passed": 3}
DEBUG | mozmill.setState | "currentState"
DEBUG | mozmill.setTest | {"name": "teardownModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js"}
DEBUG | mozmill.endTest | {"passes": [], "fails": [], "name": "testCustomization.js::teardownModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js", "failed": 0, "passed": 0}
DEBUG | mozmill.persist
DEBUG | mozmill.endRunner | true
TEST-START | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | setupModule
TEST-PASS | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testCustomization.js::setupModule
TEST-START | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testOpenCustomization
TEST-UNEXPECTED-FAIL | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testCustomization.js::testOpenCustomization
TEST-START | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | teardownModule
TEST-PASS | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testCustomization.js::teardownModule
INFO Passed: 2
INFO Failed: 1
INFO Skipped: 0

But the third run for the firefox test case passes:
failed to create drawable
DEBUG | mozmill.startRunner | true
DEBUG | mozmill.setModule | "currentModule"
DEBUG | mozmill.setState | "currentState"
DEBUG | mozmill.setTest | {"name": "setupModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js"}
DEBUG | mozmill.log | {"message": "Use controller.mainMenu instead.", "property": "controller.menus - DEPRECATED"}
INFO | Step Pass: {"function": "controller.click()"}
INFO | Step Pass: {"function": "controller.waitForEval()"}
INFO | Step Pass: {"function": "Controller.open()"}
INFO | Step Pass: {"function": "controller.waitFor()"}
INFO | Step Pass: {"function": "controller.waitForPageLoad()"}
DEBUG | mozmill.endTest | {"passes": [{"function": "controller.click()"}, {"function": "controller.waitForEval()"}, {"function": "Controller.open()"}, {"function": "controller.waitFor()"}, {"function": "controller.waitForPageLoad()"}], "fails": [], "name": "testCustomization.js::setupModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js", "failed": 0, "passed": 5}
DEBUG | mozmill.setState | "currentState"
DEBUG | mozmill.setTest | {"name": "testOpenCustomization", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js"}
INFO | Step Pass: {"function": "controller.click()"}
INFO | Step Pass: {"function": "controller.waitFor()"}
INFO | Step Pass: {"function": "Controller.waitForElement()"}
INFO | Step Pass: {"function": "jum.assertNotUndefined", "comment": "Drag target was undefined", "value": {}}
INFO | Step Pass: {"function": "jum.assertNotUndefined", "comment": "Drag target was undefined", "value": {}}
INFO | Step Pass: {"function": "controller.click()"}
INFO | Step Pass: {"function": "jum.assertNull", "value": null}
INFO | Step Pass: {"function": "jum.assertNotNull", "value": {}}
DEBUG | mozmill.endTest | {"passes": [{"function": "controller.click()"}, {"function": "controller.waitFor()"}, {"function": "Controller.waitForElement()"}, {"function": "jum.assertNotUndefined", "comment": "Drag target was undefined", "value": {}}, {"function": "jum.assertNotUndefined", "comment": "Drag target was undefined", "value": {}}, {"function": "controller.click()"}, {"function": "jum.assertNull", "value": null}, {"function": "jum.assertNotNull", "value": {}}], "fails": [], "name": "testCustomization.js::testOpenCustomization", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js", "failed": 0, "passed": 8}
DEBUG | mozmill.setState | "currentState"
DEBUG | mozmill.setTest | {"name": "teardownModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js"}
DEBUG | mozmill.endTest | {"passes": [], "fails": [], "name": "testCustomization.js::teardownModule", "filename": "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js", "failed": 0, "passed": 0}
DEBUG | mozmill.persist
DEBUG | mozmill.endRunner | true
TEST-START | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | setupModule
TEST-PASS | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testCustomization.js::setupModule
TEST-START | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testOpenCustomization
TEST-PASS | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testCustomization.js::testOpenCustomization
TEST-START | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | teardownModule
TEST-PASS | /home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/testCustomization.js | testCustomization.js::teardownModule
INFO Passed: 3
INFO Failed: 0
INFO Skipped: 0

With Thunderbird, it looks like the failure is always reproducible (the Linux version):
failed to create drawable
Warning: unrecognized command line flag -foreground
Using profile dir: /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/mozmillprofile
TEST-START | /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/message-header/test-ewait.js | setupModule
TEST-PASS | /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/message-header/test-ewait.js | test-ewait.js::setupModule
TEST-START | /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/message-header/test-ewait.js | test_with_sheet_dragndrop
Step Pass: {"function": "controller.click()"}
Step Pass: {"function": "controller.waitFor()"}
Step Pass: {"function": "Controller.waitForElement()"}
Test Failure: Drag target was undefined
TEST-UNEXPECTED-FAIL | /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/message-header/test-ewait.js | test-ewait.js::test_with_sheet_dragndrop
TEST-START | /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/message-header/test-ewait.js | teardownModule
TEST-PASS | /home/joachim/workspace/compactheader/test/test-12.0a1/mozmill/message-header/test-ewait.js | test-ewait.js::teardownModule
INFO Passed: 2
INFO Failed: 1
INFO Skipped: 0
SUMMARY-PASS | test-ewait.js::setupModule
SUMMARY-UNEXPECTED-FAIL | test-ewait.js | test-ewait.js::test_with_sheet_dragndrop
  EXCEPTION: Drag target was undefined
    at: test-folder-display-helpers.js line 2842
       assert_true((void 0),"Drag target was undefined") test-folder-display-helpers.js 2842
       drag_n_drop_element([object XULElement],[object Proxy],[object XULElement],[object Proxy],0.5,0.5,[object XULElement]) test-ewait.js 185
       test_with_sheet_dragndrop() test-ewait.js 87
            frame.js 557
            frame.js 626
            frame.js 669
            frame.js 506
            frame.js 681
            server.js 179
            server.js 183
SUMMARY-PASS | test-ewait.js::teardownModule

The thunderbird version is for both Windows and Linux is 12.0a1.
The windows firefox version is 10.0b3, the Linux version 9.0.1.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joachim Herb from comment #12)
> Firefox). But with Linux (in a virtual box) the (above) Firefox test case
> fails in the first and second run:
> failed to create drawable
> DEBUG | mozmill.startRunner | true
> DEBUG | mozmill.setModule | "currentModule"
> DEBUG | mozmill.setState | "currentState"
> DEBUG | mozmill.setTest | {"name": "setupModule", "filename":
> "/home/joachim/mozmill-env/mozmill-tests/tests/functional/testToolbar/
> testCustomization.js"}

Next time please attach the log as attachment. It makes it kinda hard to read as comment.

> Proxy])@resource://jsbridge/modules/server.js:179\n(\"e17033c4-3b0b-11e1-
> bd48-080027ac35d3\",(function (filename, invokedFromIDE) {var runner = new
> Runner(new Collector,
> invokedFromIDE);runner.runTestFile(filename);runner.end();return
> true;}),[object Proxy])@resource://jsbridge/modules/server.js:183\n",
> "message": "aTarget is null", "fileName":
> "resource://mozmill/stdlib/EventUtils.js", "name": "TypeError",
> "lineNumber": 236}}

So this fails in line 78 of the test because the homebutton is null. As I have mentioned earlier please create a new controller from the customize window itself for any further elementlib methods.

Further I would advise you to have a look at our utils.js module, especially for the handleWindow method. That one should be helpful for you and probably fixes the issue.

As I think it's just a timing issue.

Comment 14

[Joachim Herb]

I have made an observation which might explain these sporadic problems: 
It looks like the sometimes the customization dialog is hiding the toolbar and then the synthesize_drag_start function in the above patches does not work, because the event listener is never called which should trap event.dataTransfer object. 

Could this be the reason? Actually this seems to be a new bug: The header pane toolbar customization dialog is not corretly positioned when the toolbar.customization.usesheet preference is set to true. Can somebody using Mac OSX confirm this? If so, could you file a new bug for this.

(The corresponding patch was introduce here: https://bugzilla.mozilla.org/attachment.cgi?id=439729&action=diff#a/mail/base/content/mailCore.js_sec4)
Actually the "window" used there to calcule the position and size is the wrong one (the mail3pane and not the contentWindow of the iframe). 

Beside this, there is a (new) function in test-window-helpers.js wait_for_frame_load which should exactly do, what you suggested: create a mozmill controller of the contentWindow of the iframe:
http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-window-helpers.js#692

Comment 15

[Joachim Herb]

> (The corresponding patch was introduce here:
> https://bugzilla.mozilla.org/attachment.cgi?id=439729&action=diff#a/mail/
> base/content/mailCore.js_sec4)
> Actually the "window" used there to calcule the position and size is the
> wrong one (the mail3pane and not the contentWindow of the iframe). 
Just found it:
https://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/customizeToolbar.js#128
Here is the original code for repostioning of the dialog. It distinguishes between the different window types.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joachim Herb from comment #14)
> I have made an observation which might explain these sporadic problems: 
> It looks like the sometimes the customization dialog is hiding the toolbar
> and then the synthesize_drag_start function in the above patches does not
> work, because the event listener is never called which should trap
> event.dataTransfer object. 

Which means it is a bug in Firefox and Thunderbird? If that's the case it should be filed accordingly. You could implement a workaround for the time being for the Mozmill test.

> Could this be the reason? Actually this seems to be a new bug: The header
> pane toolbar customization dialog is not corretly positioned when the
> toolbar.customization.usesheet preference is set to true. Can somebody using
> Mac OSX confirm this? If so, could you file a new bug for this.

What do you mean with wrongly positioned? Looks good for me with Aurora on OS X. If I use the window instead it will be displayed shifted to the right side.

> (The corresponding patch was introduce here:
> https://bugzilla.mozilla.org/attachment.cgi?id=439729&action=diff#a/mail/
> base/content/mailCore.js_sec4)
> Actually the "window" used there to calcule the position and size is the
> wrong one (the mail3pane and not the contentWindow of the iframe). 

I can't give a qualified answer here. Talk to Mark or David or some other dev.

> Beside this, there is a (new) function in test-window-helpers.js
> wait_for_frame_load which should exactly do, what you suggested: create a
> mozmill controller of the contentWindow of the iframe:
> http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/
> test-window-helpers.js#692

Sounds good.

Comment 17

[Joachim Herb]

(In reply to Henrik Skupin (:whimboo) from comment #16)
> (In reply to Joachim Herb from comment #14)
> > I have made an observation which might explain these sporadic problems: 
> > It looks like the sometimes the customization dialog is hiding the toolbar
> > and then the synthesize_drag_start function in the above patches does not
> > work, because the event listener is never called which should trap
> > event.dataTransfer object. 
> 
> Which means it is a bug in Firefox and Thunderbird? If that's the case it
> should be filed accordingly. You could implement a workaround for the time
> being for the Mozmill test.
I think the problem is only happening with the header pane toolbar of Thunderbird, because it might be located somewhere in the middle of the screen, so it is easily hidden by another window.

I am not sure if mouse events should be "noticed" by a Thunderbird/Firefox XUL element, if the aera where the mouse is moving around, is overlayed by an IFRAME contentWindow. Should it?

> > Could this be the reason? Actually this seems to be a new bug: The header
> > pane toolbar customization dialog is not corretly positioned when the
> > toolbar.customization.usesheet preference is set to true. Can somebody using
> > Mac OSX confirm this? If so, could you file a new bug for this.
> 
> What do you mean with wrongly positioned? Looks good for me with Aurora on
> OS X. If I use the window instead it will be displayed shifted to the right
> side.
This might explain, why the test cases do not fail on your local machine. As the positioning of windows is influenced by other open windows and the screen resolution, this might also explain the sporadic behavior. 

I will try to add a tests this behavior in separated test cases. If I can reproduce it, this has to be fixed in the dialog opening code and separate mozmill tests should be added.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joachim Herb from comment #17)
> I am not sure if mouse events should be "noticed" by a Thunderbird/Firefox
> XUL element, if the aera where the mouse is moving around, is overlayed by
> an IFRAME contentWindow. Should it?

Sounds reasonable. Please talk to ndeakin or another one who knows that better than me.

Comment 19

[Joachim Herb]

I guess this bug is invalid as the problem is not caused by ewait but by the customization dialog hiding the toolbar. I can reproduce this if I add the following lines to my code:
ctc = wh.wait_for_frame_load(aController.e("customizeToolbarSheetIFrame"),
  "chrome://global/content/customizeToolbar.xul");
let toolbarX = aController.e(this._toolbarId).boxObject.screenX;
let toolbarY = aController.e(this._toolbarId).boxObject.screenY;
ctc.window.frameElement.panel.moveTo(toolbarX - 10, toolbarY - 10);

Then the problem is reproducable always.

Comment 20

[Ludovic Hirlimann [:Usul]]

So why invalid ?

Comment 21

[Joachim Herb]

(In reply to Ludovic Hirlimann [:Usul] from comment #20)
> So why invalid ?
Because it is not a bug of the testing infrastructure, i.e. the ewait function, but actually a bug of the implementation of the opening process of the dialog.