when going back in history, docshell restores zoom level in a wrong way.

NEW
Unassigned

Status

()

Core
History: Global
6 years ago
5 years ago

People

(Reporter: arno renevier, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Hi,
Lets say we visit page A, then page B.

When navigating back from page B to page A, and nsDocShell::RestoreFromHistory is called, we have, oldMUDV refering to pageA content viewer, and newMUDV refering to pageB content viewer.
And newMUDV full zoom is set to oldMUDV.
This means that zoom of newly visited page is set back to previously visited page. I think this is not the right thing to do.
To reproduce:
- set browser.zoom.siteSpecific to false
- go to some page where cache will be activated. For example http://www.debian.org/
- unzoom a lot to make text small
- go to some other page. For example http://www.debian.org/distrib/
- zoom a lot to make text big
- go back.
- text is big

expected result:
- text should be small
(Reporter)

Comment 1

6 years ago
Created attachment 556014 [details] [diff] [review]
patch (without tests)

Here is a patch fixing the issue.
I've uploaded it on try server and it shows no apparent regression:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=1f71931c402c
I'm now waiting for #681392 to be fixed to write a relevant test.
(Reporter)

Updated

6 years ago
Depends on: 681392
You need to log in before you can comment on or make changes to this bug.