Last Comment Bug 681397 - when going back in history, docshell restores zoom level in a wrong way.
: when going back in history, docshell restores zoom level in a wrong way.
Status: NEW
Product: Core
Classification: Components
Component: History: Global (show other bugs)
: unspecified
: x86_64 Linux
-- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
: Marco Bonardo [::mak]
Depends on: 681392
  Show dependency treegraph
Reported: 2011-08-23 11:01 PDT by arno renevier
Modified: 2012-10-17 12:38 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (without tests) (2.39 KB, patch)
2011-08-26 06:40 PDT, arno renevier
no flags Details | Diff | Splinter Review

Description User image arno renevier 2011-08-23 11:01:22 PDT
Lets say we visit page A, then page B.

When navigating back from page B to page A, and nsDocShell::RestoreFromHistory is called, we have, oldMUDV refering to pageA content viewer, and newMUDV refering to pageB content viewer.
And newMUDV full zoom is set to oldMUDV.
This means that zoom of newly visited page is set back to previously visited page. I think this is not the right thing to do.
To reproduce:
- set browser.zoom.siteSpecific to false
- go to some page where cache will be activated. For example
- unzoom a lot to make text small
- go to some other page. For example
- zoom a lot to make text big
- go back.
- text is big

expected result:
- text should be small
Comment 1 User image arno renevier 2011-08-26 06:40:27 PDT
Created attachment 556014 [details] [diff] [review]
patch (without tests)

Here is a patch fixing the issue.
I've uploaded it on try server and it shows no apparent regression:
I'm now waiting for #681392 to be fixed to write a relevant test.

Note You need to log in before you can comment on or make changes to this bug.