Closed
Bug 681425
Opened 13 years ago
Closed 13 years ago
Tabs in Firefox (Preferences) should look and feel like native OS X tabs
Categories
(Firefox :: Theme, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: Dominic.Spitaler, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
122.58 KB,
image/png
|
Details | |
1.25 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
The tabs under Preferences->Advanced (and maybe elsewhere?) don’t look and feel exactly like native OS X tabs. - They shouldn’t have a blue highlight/glow around them - Text in the selected tab should be white (in Lion) - Tab switching should occur on a mouse-release event and not on mouse-down - Pressed state (for selected and unselected tabs) is therefore missing too This is of course not very severe, or even important, but let’s track it anyway. Maybe it’s an easy fix.
Comment 1•13 years ago
|
||
(In reply to Dominic Spitaler from comment #0) > - They shouldn’t have a blue highlight/glow around them That is the focus ring, which is intended. It should only appear if you tab to the control though.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 2•13 years ago
|
||
I thought it was intended, I just wanted to point out that it’s unusual for OS X.
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Dominic Spitaler from comment #2) > I thought it was intended, I just wanted to point out that it’s unusual for > OS X. Wops, sorry now I get it. it’s meant for keybord-access, sorry.
Assignee | ||
Comment 5•13 years ago
|
||
Updated•13 years ago
|
Attachment #574070 -
Flags: review?(dao) → review+
Comment 6•13 years ago
|
||
Markus, can this be landed now or are you waiting to land it with something else?
Comment 8•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ecb0201e044
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Reporter | ||
Comment 9•13 years ago
|
||
While looking like native OS X tabs, they do not behave exactly like them. A tab should be activated on release not on press. I also still get the blue focus ring when switching between tabs with the mouse.
Comment 10•13 years ago
|
||
(In reply to Dominic Spitaler from comment #9) > While looking like native OS X tabs, they do not behave exactly like them. A > tab should be activated on release not on press. I also still get the blue > focus ring when switching between tabs with the mouse. Thanks for following up on that, but can you file a new bug for the clicked state / behavior part of it? This bug got morphed into just handling the color of the tabs.
Reporter | ||
Comment 11•12 years ago
|
||
done that: https://bugzilla.mozilla.org/show_bug.cgi?id=712083
You need to log in
before you can comment on or make changes to this bug.
Description
•