Closed Bug 681519 Opened 8 years ago Closed 8 years ago

ID for change.synckey.acceptButton has not been changed

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla9

People

(Reporter: unghost, Assigned: philikon)

References

Details

Attachments

(1 file)

From Bug 656492:

> -change.synckey.acceptButton = Change Sync Key
> +change.synckey.acceptButton = Change Recovery Key

ID for change.synckey.acceptButton in syncGenericChange.properties has not been changed. It should be changed for l10n purposes.
It's changed in change.recovery.acceptButton in syncGenericChange.js so I suspect that now UI is broken.
Even worse, the code that uses the string was updated, but to a nonsensical string ID. Should've spotted this in review, my bad.
Assignee: nobody → philipp
Attached patch v1Splinter Review
There was one more string ID that wasn't correct. Also removed an unused string.
Attachment #555269 - Flags: review?(rnewman)
Comment on attachment 555269 [details] [diff] [review]
v1

Review of attachment 555269 [details] [diff] [review]:
-----------------------------------------------------------------

m-i! m-i!
Attachment #555269 - Flags: review?(rnewman) → review+
http://hg.mozilla.org/mozilla-central/rev/198c7de0699d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
STRs for QA:

Apart from the fact that the string ID wasn't renamed, there were also two bugs concerning the the button and the explanatory text in the "My Sync Key" dialog. Those labels weren't updated and an exception occurred in the Error Console. These were fixed.
verified on m-c
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.