681617 - some text in ldapAutoCompErrs.properties are not right for Thunderbird

Status: NEW

(Thunderbird :: Address Book, defect)

Description

[Tim Maks van den Broek [:mad_maks]]

comm-central/mail/locales/en-US/chrome/messenger/addressbook/ldapAutoCompErrs.properties

for example:

10021=Verify that the search filter is correct, and then try again, or else contact your System Administrator. To verify that the search filter is correct, from the Edit menu, choose Preferences, then choose Mail & Newsgroups, and then choose Addressing. Click Edit Directories, and select the LDAP server being used. Click Edit, and then click Advanced to display the Search Filter.

In Thunderbird you can't choose Mail & Newsgroups

Comment 1

[Ludovic Hirlimann [:Usul]]

Tim can you propose a patch ?

Comment 2

[Tim Maks van den Broek [:mad_maks]]

sure but what to do for l10n. normaly the entityname change but in this file?

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to Tim Maks van den Broek from comment #2)
> sure but what to do for l10n. normaly the entityname change but in this file?

Axel ?

Comment 4

[Tim Maks van den Broek [:mad_maks]]

Attachment: ldapAutoCompErrs.diff

Patch with the text change. No entity change until i learn from pike what to do in this case

Comment 5

[Tim Maks van den Broek [:mad_maks]]

One other thing, we talk here about Edit=> Preferences, that is right for linux but is this also right for windows?

Comment 6

[Axel Hecht [:Pike]]

Looking at the sources of our localizations, we should change the keys.

And oh my eyes, I don't like to look at mailnews language ID code.

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to Tim Maks van den Broek from comment #5)
> One other thing, we talk here about Edit=> Preferences, that is right for
> linux but is this also right for windows?

On windows it's Tools -> Options and on macos it's Thunderbird -> Preferences

Comment 8

[Tim Maks van den Broek [:mad_maks]]

(In reply to Ludovic Hirlimann [:Usul] from comment #7)
> (In reply to Tim Maks van den Broek from comment #5)
> > One other thing, we talk here about Edit=> Preferences, that is right for
> > linux but is this also right for windows?
> 
> On windows it's Tools -> Options and on macos it's Thunderbird -> Preferences

So there is a lot wrong in this file or is it only showed to linux/mac users?

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 558139 [details] [diff] [review]
ldapAutoCompErrs.diff

Review of attachment 558139 [details] [diff] [review]:
-----------------------------------------------------------------

So, given that approximately 90% of Thunderbird's users are on Windows, I think the very least we should do is use the Windows locations for these menu items.
Better would be to have all three locations listed, and better still would be to figure out a platform-independent way to refer to the items we're talking about.
Best of all might be to have all three locations in our source, but only show the appropriate one based on the user's current platform.

Thanks,
Blake.

Comment 10

[Tim Maks van den Broek [:mad_maks]]

from the Edit menu, choose Preferences, then choose

if we drop the line 'from the Edit menu' and change 'preferences' in 'Options/Preferences' we will cover all platforms and we don't need to change the coding (i can't code :( ).

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 558139 [details] [diff] [review]
ldapAutoCompErrs.diff

Cancelling review request until the ui-review is resolved.

Comment 12

[Michael Wolf]

When is the patch applied to Thunderbird? Now we are in 2014 (3 years later!) and there are still wrong strings in file ldapAutoCompErrs.properties, e.g. 10021, 10032, 10081, 10087, 100091 and 15000.

Comment 13

[Ludovic Hirlimann [:Usul]]

(In reply to Michael Wolf from comment #12)
> When is the patch applied to Thunderbird? Now we are in 2014 (3 years
> later!) and there are still wrong strings in file
> ldapAutoCompErrs.properties, e.g. 10021, 10032, 10081, 10087, 100091 and
> 15000.

We need someone to work on fixing the bug again.

Comment 14

[:aceman]

This would be a good opportunity to convert the numeric string IDs to strings.