Closed
Bug 681741
Opened 13 years ago
Closed 13 years ago
IonMonkey: Assertion failure: casepc > pc && casepc <= exitpc
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: h4writer)
References
Details
Attachments
(1 file)
4.62 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
$ ./Debug32/js --ion jit-test/tests/jaeger/tableSwitchNeg.js Assertion failure: casepc > pc && casepc <= exitpc, at /home/dvander/mozilla/ionmonkey-central/js/src/ion/IonBuilder.cpp:1319 Aborted
Assignee | ||
Comment 1•13 years ago
|
||
This happened when the numbers of the cases in the switch weren't consecutive, but almost. Then the interpreter will fill the gaps with references to the default case. I forgot to support that in my implementation.
Assignee: general → hv1989
Attachment #555604 -
Flags: review?(dvander)
Reporter | ||
Updated•13 years ago
|
Attachment #555604 -
Attachment is patch: true
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 555604 [details] [diff] [review] Support jumps to default case in the jumptable Review of attachment 555604 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/IonBuilder.cpp @@ +1324,5 @@ > > + // If the casepc equals the current pc, > + // it is not a written case, but a filled gap. > + // That way we can use a tableswitch instead of lookupswitch, > + // even if not all numbers are consecutive. You can wrap comment text to 80 columns :) might look a little less squashed ::: js/src/ion/MIR.h @@ +556,5 @@ > Vector<MBasicBlock*, 0, IonAllocPolicy> successors_; > + > + // Contains the cases in order of the jump table. > + // So it contains the consecutive cases. > + // If the code doesn't contain that number, it goes to the default case. This might read better as: "Contains the consecutive targets of each case."
Attachment #555604 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/43a2d1a79064 last fixed bug for this internship :( luckily I can still fix bugs at home ;)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•