Closed Bug 68175 Opened 24 years ago Closed 23 years ago

if rapidly click on Message Filters listbox scroll bar down arrow, Filter Rules dialog pops up

Categories

(MailNews Core :: Filters, defect)

x86
All
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: ekrock, Assigned: hwaara)

References

Details

Attachments

(1 file)

Using N6 Commercial 2001020520 on WinNT 4.0 SP5/6 (not sure).

Using a Messenger that has at least enough filters defined to fill up the Mail
Filters list box and cause the scroll bars to be enabled:

To repro:
1) open Messenger
2) Edit-->Message Filters
3) click as fast as you can about six times on the list box down arrow

Expected: events are cached and handled in order and you scroll down six filters
Actual: Filter Rules dialog pops up, which is undesirable behavior

This is annoying but not fatal. The workaround is to click more slowly on the
scroll arrow.
QA Contact: esther → laurel
Summary: if rapidly click on Message Filters listbox scroll bar down arrow, Filter Rules dialog pops up → if rapidly click on Message Filters listbox scroll bar down arrow, Filter Rules dialog pops up
The same if you double-click on the little arrows to move the scroll bar.
Just wanted to say that this annoying bug exists in this release too.

Mozilla 0.9+
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9+) Gecko/20010515
BuildID: 2001051520
reassigning to naving
Assignee: gayatrib → naving
*** Bug 82914 has been marked as a duplicate of this bug. ***
*** Bug 84419 has been marked as a duplicate of this bug. ***
Taking, I've got a fix.
Assignee: naving → hwaara
Attached patch simple fixSplinter Review
The problem was that the ondoubleclick event fired for the tree where ever one
clicked. So you could double click on a scrollbar and still get the "New Filter"
dialog pop up.

The fix was simply to check that the click came from a treecell. Naving, Seth
please review.
OS: Windows NT → All
Target Milestone: --- → mozilla0.9.3
Keywords: patch, review
Target Milestone: mozilla0.9.3 → mozilla0.9.2
r=naving for the double-click issue but this does nothing about events being
cached. 
Sspitzer, can you sr= this little baby?
sr=sspitzer

after your fix:

1) does double clicking on the column header open up the filter rules dialog?
2) does double clicking on the "enabled cell" (the green dot) open the filter
rules dialog?

if they do, those should be new bugs.
#1 occurs, but not #2.

Seth, which component should #1 be filed against? XPToolkit?
no, I think you have to fix #1 is your js.

I think you have to check if the treecell's parent parent is a treerow or a
treeitem (or something like that.)

a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Blocks: 83989
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
fix checked in with a slightly different fix and sr=sspitzer for that.
OK with june20-21 commercial trunk builds, win98, mac OS 9.0 and linux rh6.2
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: