681814 - Mochitests should show the slavename in the scrape

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Phil Ringnalda (:philor)]

Tinderbox-based tbpl shows the slave name in both the summary popup and at the top of the brief log (well, that part is Tinderbox), but with usebuildbot=1, you don't get the slave name in the summary, and you don't get it from getParsedLog.php except with &full=1. That makes it harder to notice that just one slave is the one that keeps doing foo, and more of a hassle to ping |buildduty about which slave did bar and needs a smacking.

Comment 1

[Phil Ringnalda (:philor)]

Probably the best thing to do is to stop hiding it in the scrape (since it can be useful to know either "that green run was on the same slave" or "that one green run was because it was a different slave" even though we don't show a popup for green runs), but that's dependent on bug 582697 and its dependencies to clean up both our regexes and releng's TinderboxPrinting.

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

this would also be great for me when looking at the output of tinderboxpuslog robot.

Comment 3

[Phil Ringnalda (:philor)]

I had high hopes that someone smart would just fix this for me everywhere, but given that that's not going to happen, I split it into bite-size chunks, some of which I'll be able to do.

bug 713574 for tbplbot bug comments
bug 713575 for brief logs
bug 713576 for Talos scrape

Comment 4

[Phil Ringnalda (:philor)]

Attachment: fix v.1

Arguably, the right fix here is to dismantle the whole elegant whateverthatis that picks which function to call, since talos is now done before it ever gets down there, Everythingelse I think died with 1.9.1, if not before, Unit Test probably wants the same generic scraper that doesn't drop slavename treatment, at which point everything is either generic or talos. However, since we throw away logs after four days right now and the newest Unit Test run is two weeks old, I'd have to trigger a full set of builds and tests on every platform on 1.9.2 just to be sure it doesn't have garbage in its scrape, and the function is such an elegant assemblage of braces and parens and bits and bobs that the last time I tried to dismantle it, I couldn't even get to where I could tell what the syntax error I caused meant.

So, this gives me the slavename in the scrape for mochitests, which makes me happy.

Comment 5

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/41771aa6b388