681894 - GCLI should not have the assignment.field hack

Status: RESOLVED WONTFIX

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P4)

Description

[Joe Walker [:jwalker]]

arg_fetch.html:

    <table foreach="assignment in ${requ.getAssignments()}">
      <tr>
        <td>${assignment.param.description}</td>
        <td>${getInputFor(assignment)}</td>
      </tr>
      <tr>
        <td colspan="2">${linkMessageElement(assignment, __element)}</td>
      </tr>
    </table>

Which calls getInputFor(assignment) and linkMessageElement(assignment,...).
The problem is that getInputFor creates a Field, which wants to know about the message element created by linkMessageElement.

Rather than assume the DOM structure created by arg_fetch.html, we have getInputFor() squirrel away the Field in the assignment:

    ArgFetcher.getInputFor = function(assignment) {
      var newField = getField(...);
      // setup events
      
      // HACK!
      assignment.field = newField;
      
      return newField.element;
    }

So it can be picked up by linkMessageElement:

    ArgFetcher.linkMessageElement = function(assignment, element) {
      // HACK!
      var field = assignment.field;
      delete assignment.field;
      
      field.setMessageElement(element);
      return '';
    }

Better fix suggestions welcome.

Comment 1

[Joe Walker [:jwalker]]

Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.

Comment 2

[Joe Walker [:jwalker]]

Triage. Filter on PEGASUS.

Comment 3

[Joe Walker [:jwalker]]

Triage. Filter on PEGASUS.

Comment 4

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"