Closed Bug 681938 Opened 9 years ago Closed 9 years ago

Failure in /testAwesomeBar/testAccessLocationBar.js | Timeout exceeded for 'subject.selectedIndex == 0'

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: remus.pop, Assigned: remus.pop)

References

()

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(1 file, 2 obsolete files)

TEST: testAccessLocationBar.js::testAccessLocationBarHistory
ERROR: controller.waitForEval: Timeout exceeded for 'subject.selectedIndex == 0'
WHEN: 2011-08-25
FIRST: 2011-08-25
FREQ: 1
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/17469091
Attached patch proposed patch (obsolete) — Splinter Review
I'm suspecting that a controller.sleep(100) was causing this failure so I used a waitFor function instead of.
Attachment #555727 - Flags: review?(alex.lakatos)
Comment on attachment 555727 [details] [diff] [review]
proposed patch

>+function testAccessLocationBarHistory()
> {
Please follow the style guide. This should be:
function testAccessLocationBarHistory() {

>+  controller.waitFor(function () {
>+    return autoCompleteResults.isOpened;
>+  }, "Autocomplete results should be visible", 1000, 100);
Please use a constant for the timeout value.
  }, "Autocomplete results should be visible", TIMEOUT, 100);
Attachment #555727 - Flags: review?(alex.lakatos) → review-
(In reply to Alex Lakatos from comment #3)
> >+  controller.waitFor(function () {
> >+    return autoCompleteResults.isOpened;
> >+  }, "Autocomplete results should be visible", 1000, 100);
> Please use a constant for the timeout value.
>   }, "Autocomplete results should be visible", TIMEOUT, 100);

I would propose to use the default values for both the timeout and the delay. No need to specify those at all.
Attached patch patch v2 (obsolete) — Splinter Review
Modified the patch as requested.
Attachment #555727 - Attachment is obsolete: true
Attachment #556503 - Flags: review?(alex.lakatos)
Attachment #556503 - Flags: review?(anthony.s.hughes)
Attachment #556503 - Flags: review?(alex.lakatos)
Attachment #556503 - Flags: review+
Comment on attachment 556503 [details] [diff] [review]
patch v2

>+  controller.waitFor(function () {
>+    return locationBar.autoCompleteResults.selectedIndex == 0;
>+  }, "The first item should be selected");

Please use === and expected/got in the message in this case. This way we can see what index is selected when we do fail.
Attachment #556503 - Flags: review?(anthony.s.hughes) → review-
Added requested changes.
Attachment #556503 - Attachment is obsolete: true
Attachment #557120 - Flags: review?(anthony.s.hughes)
Attachment #557120 - Flags: review?(anthony.s.hughes) → review+
Please mark this VERIFIED if the failure is no longer present tomorrow.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This is no longer appearing in the test runs.
Status: RESOLVED → VERIFIED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.