Last Comment Bug 682051 - Optimize textframe handling of a single large textrun during a horizontal resize
: Optimize textframe handling of a single large textrun during a horizontal resize
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86 Mac OS X
: P1 normal (vote)
: mozilla9
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on:
Blocks: 561578 680461
  Show dependency treegraph
 
Reported: 2011-08-25 12:05 PDT by Boris Zbarsky [:bz]
Modified: 2011-08-26 13:56 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Optimize textframe to handle horizontal resizes of large runs of text better. change does two things: (8.63 KB, patch)
2011-08-25 12:19 PDT, Boris Zbarsky [:bz]
roc: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2011-08-25 12:05:06 PDT
This is spun off from bug 561578 to handle the textframe parts of that bug.  The blockframe parts are more painful, sadly.
Comment 1 Boris Zbarsky [:bz] 2011-08-25 12:19:36 PDT
Created attachment 555808 [details] [diff] [review]
Optimize textframe to handle horizontal resizes of large runs of text better.   change does two things:
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-08-25 19:42:05 PDT
Comment on attachment 555808 [details] [diff] [review]
Optimize textframe to handle horizontal resizes of large runs of text better.   change does two things:

Review of attachment 555808 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsTextFrameThebes.cpp
@@ +6680,5 @@
>    return PR_FALSE;
>  }
>  
> +static void
> +RemoveInFlows(nsIFrame* f, nsIFrame* firstToNotRemove)

aFrame, aFirstToNotRemove
Comment 3 Boris Zbarsky [:bz] 2011-08-25 20:30:29 PDT
Made those changes and pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/171e1d0b8cb3

Not sure how to write a test for this....  It's way too likely to regress.  :(
Comment 4 Matt Brubeck (:mbrubeck) 2011-08-26 09:28:15 PDT
http://hg.mozilla.org/mozilla-central/rev/171e1d0b8cb3

Note You need to log in before you can comment on or make changes to this bug.