Closed Bug 682051 Opened 8 years ago Closed 8 years ago

Optimize textframe handling of a single large textrun during a horizontal resize

Categories

(Core :: Layout, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

This is spun off from bug 561578 to handle the textframe parts of that bug.  The blockframe parts are more painful, sadly.
Blocks: 680461
Whiteboard: [need review]
Comment on attachment 555808 [details] [diff] [review]
Optimize textframe to handle horizontal resizes of large runs of text better.   change does two things:

Review of attachment 555808 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsTextFrameThebes.cpp
@@ +6680,5 @@
>    return PR_FALSE;
>  }
>  
> +static void
> +RemoveInFlows(nsIFrame* f, nsIFrame* firstToNotRemove)

aFrame, aFirstToNotRemove
Attachment #555808 - Flags: review?(roc) → review+
Made those changes and pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/171e1d0b8cb3

Not sure how to write a test for this....  It's way too likely to regress.  :(
Whiteboard: [need review]
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/171e1d0b8cb3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.