Revised attachment view doesn't work well with personas

RESOLVED FIXED in Thunderbird 10.0

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: Paenglab)

Tracking

6 Branch
Thunderbird 10.0

Thunderbird Tracking Flags

(thunderbird7-, thunderbird8-, thunderbird9+ fixed)

Details

Attachments

(1 attachment)

If I select a persona and view a message with an attachment, then I get the text colour set by the persona, not to the normal black as per the buttons in the message header.
Personally, I think we should just make the Mac theme look like the Windows/Linux themes here. I'm not really a fan of the current style.
(In reply to Jim Porter (:squib) from comment #1)
> Personally, I think we should just make the Mac theme look like the
> Windows/Linux themes here. I'm not really a fan of the current style.

Whilst that's a possibility, I'd like to get a quick-fix in for this issue for 7, as I think then its safe to promote personas a bit more. We can rearrange how the mac theme looks in a follow-up bug.
Whiteboard: [needs verification in 8]
OS: Mac OS X → All
Whiteboard: [needs verification in 8]
This patch gives the whole tabmail a color to override the personas color which is not needed in this area. I gave the same color as is used when no persona is used (defined for window).
Attachment #566257 - Flags: review?(bwinton)
Attachment #566257 - Attachment description: Give color: -moz-DialogText; for thwhole tabmail → Give color: -moz-DialogText; for the whole tabmail
Assignee: nobody → richard.marti
Comment on attachment 566257 [details] [diff] [review]
Give color: -moz-DialogText; for the whole tabmail

Review of attachment 566257 [details] [diff] [review]:
-----------------------------------------------------------------

That seems to fix it, although I notice that the tab titles are really hard to read…  I'm not sure whether we want to fix that here or in the tabs-on-top patch…  Either way, r=me for this bit.

Thanks,
Blake.
Attachment #566257 - Flags: review?(bwinton) → review+
The tab titles are already fixed the tabs-on-top patch ;)
Status: NEW → ASSIGNED
Keywords: checkin-needed
Checked in as http://hg.mozilla.org/comm-central/rev/599195f0ef00
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
Comment on attachment 566257 [details] [diff] [review]
Give color: -moz-DialogText; for the whole tabmail

Apparently, we're tracking this for TB 9, so requesting approval for comm-aurora.
Attachment #566257 - Flags: approval-comm-aurora?
Attachment #566257 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.