Closed Bug 682142 Opened 13 years ago Closed 13 years ago

Move most app "features" into "shareTypes"

Categories

(Mozilla Labs :: F1, defect)

x86_64
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

The link.send API currently stores attributes such as "textLimit", "subject" etc in the features field for the app.  However, all of these fields are actually attributes of the shareType, not a generic feature of the app itself.

Eg, consider if the facebook app support sending via facebook email:  for a normal wall post we want no subject and a 420 char text limit, but for email we probably have no limit and do want a subject.
Attachment #555907 - Flags: review?(mixedpuppy)
Comment on attachment 555907 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/1

r+ with removal of the f1-disabled functionality, and adding any considerations on shareTypes per the discussion about shareTypes with ben and documenting them on https://github.com/mozilla/openwebapps/blob/develop/docs/SHARE_ACTIVITY.md
Attachment #555907 - Flags: review?(mixedpuppy) → review+
Ben doesn't think this should happen.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: