Move most app "features" into "shareTypes"

RESOLVED INVALID

Status

Mozilla Labs
F1
RESOLVED INVALID
6 years ago
6 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

Trunk
x86_64
Windows Vista

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The link.send API currently stores attributes such as "textLimit", "subject" etc in the features field for the app.  However, all of these fields are actually attributes of the shareType, not a generic feature of the app itself.

Eg, consider if the facebook app support sending via facebook email:  for a normal wall post we want no subject and a 420 char text limit, but for email we probably have no limit and do want a subject.
(Assignee)

Comment 1

6 years ago
Created attachment 555907 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/1

Pointer to Github pull-request
(Assignee)

Updated

6 years ago
Attachment #555907 - Flags: review?(mixedpuppy)
Comment on attachment 555907 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/1

r+ with removal of the f1-disabled functionality, and adding any considerations on shareTypes per the discussion about shareTypes with ben and documenting them on https://github.com/mozilla/openwebapps/blob/develop/docs/SHARE_ACTIVITY.md
Attachment #555907 - Flags: review?(mixedpuppy) → review+
(Assignee)

Comment 3

6 years ago
Ben doesn't think this should happen.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.