Last Comment Bug 682142 - Move most app "features" into "shareTypes"
: Move most app "features" into "shareTypes"
Status: RESOLVED INVALID
:
Product: Mozilla Labs
Classification: Other
Component: F1 (show other bugs)
: Trunk
: x86_64 Windows Vista
: -- normal (vote)
: ---
Assigned To: Mark Hammond [:markh]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-25 15:59 PDT by Mark Hammond [:markh]
Modified: 2011-08-26 19:27 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/1 (364 bytes, text/html)
2011-08-25 17:58 PDT, Mark Hammond [:markh]
mixedpuppy: review+
Details

Description Mark Hammond [:markh] 2011-08-25 15:59:10 PDT
The link.send API currently stores attributes such as "textLimit", "subject" etc in the features field for the app.  However, all of these fields are actually attributes of the shareType, not a generic feature of the app itself.

Eg, consider if the facebook app support sending via facebook email:  for a normal wall post we want no subject and a 420 char text limit, but for email we probably have no limit and do want a subject.
Comment 1 Mark Hammond [:markh] 2011-08-25 17:58:46 PDT
Created attachment 555907 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/1

Pointer to Github pull-request
Comment 2 Shane Caraveo (:mixedpuppy) [on leave 5/16-7/16] 2011-08-26 18:45:38 PDT
Comment on attachment 555907 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/1

r+ with removal of the f1-disabled functionality, and adding any considerations on shareTypes per the discussion about shareTypes with ben and documenting them on https://github.com/mozilla/openwebapps/blob/develop/docs/SHARE_ACTIVITY.md
Comment 3 Mark Hammond [:markh] 2011-08-26 19:27:19 PDT
Ben doesn't think this should happen.

Note You need to log in before you can comment on or make changes to this bug.