682147 - PGO build failure due to 'make package' malfunction

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

With bug 665978 backed out locally to avoid bug 675084, I'm seeing the below build failure currently. Clean objdir to start, PGO build, pymake, MSVC 2010 SP1, Win7 x64.

make.py[2]: Leaving directory 'c:\mozbuild\mozilla-central'
make.py[2]: Entering directory 'c:/mozbuild/mozilla-central/objdir-fx'
make.py[2]: Leaving directory 'c:/mozbuild/mozilla-central/objdir-fx'
c:\mozbuild\mozilla-central\client.mk:214:0$ OBJDIR=c:/mozbuild/mozilla-central/objdir-fx JARLOG_DIR=c:/mozbuild/mozilla-central/objdir-fx/jarlog/en-US python c:/mozbuild/mozilla-central/objdir-fx/_profile/pgo/profileserver.py
args: ['c:\\mozbuild\\mozilla-central\\objdir-fx\\dist\\firefox\\firefox.exe', '-no-remote', '-profile', 'c:\\mozbuild\\mozilla-central\\objdir-fx\\_profile\\pgo\\pgoprofile/', 'http://localhost:8888/index.html']
Traceback (most recent call last):
  File "c:/mozbuild/mozilla-central/objdir-fx/_profile/pgo/profileserver.py", line 92, in <module>
    timeout = None)
  File "c:\mozbuild\mozilla-central\objdir-fx\_profile\pgo\automation.py", line 855, in runApp
    stderr = subprocess.STDOUT)
  File "c:\mozbuild\mozilla-central\objdir-fx\_profile\pgo\automation.py", line 173, in __init__
    universal_newlines, startupinfo, creationflags)
  File "c:\mozbuild\python\lib\subprocess.py", line 633, in __init__
    errread, errwrite)
  File "c:\mozbuild\python\lib\subprocess.py", line 842, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
c:\mozbuild\mozilla-central\client.mk:214:0: command 'OBJDIR=c:/mozbuild/mozilla-central/objdir-fx JARLOG_DIR=c:/mozbuild/mozilla-central/objdir-fx/jarlog/en-US python c:/mozbuild/mozilla-central/objdir-fx/_profile/pgo/profileserver.py' failed, return code 1
c:\mozbuild\mozilla-central\client.mk:174:0: command 'c:/mozbuild/python/python.exe c:/mozbuild/mozilla-central/build/pymake/pymake/../make.py -f c:/mozbuild/mozilla-central/client.mk profiledbuild' failed, return code 2

Comment 1

[(not currently active) Ted Mielczarek]

Does c:\\mozbuild\\mozilla-central\\objdir-fx\\dist\\firefox\\firefox.exe exist? (We should have run "make package" before running the profiling step.)

Comment 2

[Ryan VanderMeulen [:RyanVM]]

make package did not run

Comment 3

[(not currently active) Ted Mielczarek]

Hrm. Do you still have the build log? It really should run:
http://mxr.mozilla.org/mozilla-central/source/client.mk#211

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: End of the build log

I don't have a full log, but here's the end of the build. This shows it skipping over the package phase.

Actually, something more interesting. It looks like make package is a no-op.
$ python -OO ../build/pymake/make.py package
make.py[0]: Entering directory 'c:\mozbuild\mozilla-central\objdir-fx'
make.py[0]: Leaving directory 'c:\mozbuild\mozilla-central\objdir-fx'

Comment 5

[Ryan VanderMeulen [:RyanVM]]

For the record, I'm seeing this no-op behavior on two different computers now. Same environment for both. I tried deleting make.pyc to see if that would help, but it did not.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Seeing this in a non-pymake build as well. This is the output from a regular PGO build started with make -f client.mk in an empty objdir.

make -C /c/mozbuild/mozilla-central/objdir-fx package
make[2]: Entering directory `/c/mozbuild/mozilla-central/objdir-fx'
make[2]: `/c/mozbuild/mozilla-central/package' is up to date.
make[2]: Leaving directory `/c/mozbuild/mozilla-central/objdir-fx'

Comment 7

[Mike Hommey [:glandium]]

This just means you have a "package" file or directory in c:\mozbuild\mozilla-central, which is not part of the mozilla code-base. Turning the rule PHONY in browser/build.mk would work around the issue, but the root problem is that you have a file there that doesn't belong.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Yes, I'm an idiot. Thanks Mike.