Last Comment Bug 682239 - Tests all HTMLFormElement attributes reflection
: Tests all HTMLFormElement attributes reflection
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Mounir Lamouri (:mounir)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-26 02:42 PDT by Mounir Lamouri (:mounir)
Modified: 2011-08-27 01:47 PDT (History)
2 users (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (14.01 KB, patch)
2011-08-26 03:32 PDT, Mounir Lamouri (:mounir)
Ms2ger: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-08-26 02:42:33 PDT

    
Comment 1 Mounir Lamouri (:mounir) 2011-08-26 03:32:28 PDT
Created attachment 555989 [details] [diff] [review]
Patch v1
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-08-26 06:17:35 PDT
Comment on attachment 555989 [details] [diff] [review]
Patch v1

r=me with this addressed

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
 function reflectLimitedEnumerated(aParameters)
 {
   var element = aParameters.element;
-  var attr = aParameters.attribute;
+  var contentAttr = typeof aParameters.attribute === "string"
+                      ? aParameters.attribute : aParameters.attribute.content;
+  var idlAttr = typeof aParameters.attribute === "string"
+                  ? aParameters.attribute : aParameters.attribute.idl;
   var defaultValue = aParameters.defaultValue !== undefined
     ? aParameters.defaultValue : "";
   var unsupportedValues = aParameters.unsupportedValues !== undefined
     ? aParameters.unsupportedValues : [];

Please make the indentation match for these four; either way is fine.

--- a/content/html/content/test/test_bug585508.html
+++ b/content/html/content/test/test_bug585508.html
 var button = document.createElement('button');
 checkAttribute(button, 'formenctype', 'formEnctype', enctypeTestData);
 checkAttribute(button, 'formmethod', 'formMethod', methodTestData);

And I seem to remember you were planning to fix bug 673553?
Comment 3 Marco Bonardo [::mak] 2011-08-27 01:47:09 PDT
http://hg.mozilla.org/mozilla-central/rev/3faac1e63f57

Note You need to log in before you can comment on or make changes to this bug.