The default bug view has changed. See this FAQ.

Tests all HTMLFormElement attributes reflection

RESOLVED FIXED in mozilla9

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 555989 [details] [diff] [review]
Patch v1
Attachment #555989 - Flags: review?(Ms2ger)
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Comment on attachment 555989 [details] [diff] [review]
Patch v1

r=me with this addressed

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
 function reflectLimitedEnumerated(aParameters)
 {
   var element = aParameters.element;
-  var attr = aParameters.attribute;
+  var contentAttr = typeof aParameters.attribute === "string"
+                      ? aParameters.attribute : aParameters.attribute.content;
+  var idlAttr = typeof aParameters.attribute === "string"
+                  ? aParameters.attribute : aParameters.attribute.idl;
   var defaultValue = aParameters.defaultValue !== undefined
     ? aParameters.defaultValue : "";
   var unsupportedValues = aParameters.unsupportedValues !== undefined
     ? aParameters.unsupportedValues : [];

Please make the indentation match for these four; either way is fine.

--- a/content/html/content/test/test_bug585508.html
+++ b/content/html/content/test/test_bug585508.html
 var button = document.createElement('button');
 checkAttribute(button, 'formenctype', 'formEnctype', enctypeTestData);
 checkAttribute(button, 'formmethod', 'formMethod', methodTestData);

And I seem to remember you were planning to fix bug 673553?
Attachment #555989 - Flags: review?(Ms2ger) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [inb]
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
Whiteboard: [inb] → [inbound]
http://hg.mozilla.org/mozilla-central/rev/3faac1e63f57
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.