682281 - Change Password button on Edit Your Profile doesn't save form data

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Austin King [:ozten]]

This is a UX bug.

1) Login
2) Click Edit Your Profile
3) Modify your First Name (or other attributes
4) Click the 'Change Password' button

Actual:
Move to /en-US/password_change.
First name is not updated

Expected:
This link shouldn't look like a button. it is a form of navigation.
Otherwise if it is a button, it should submit the form and then eventually redirect to /{locale}/password_change.

Comment 1

[Aakash Desai [:aakashd]]

This should be fixed in 1.0 Triaging as such :)

Comment 2

[tofumatt [:tofumatt]]

I've closed this up in an upcoming commit; the password link is now styled as a link, not a button. It still doesn't submit form data; I'd be open to a JS alert warning users that they have unsaved data, though the back button on any modern browser should refill their information if I recall correctly.

I'll close the bug when it's up on -dev

Comment 3

[Aakash Desai [:aakashd]]

This password link is styled as a link on staging and dev now. The form is not submitting, but that might be due to bug 688121

Comment 4

[tofumatt [:tofumatt]]

The form should *not* submit when you click the change password link; the link takes you to another page (this is expected behaviour of a link).

Now that there isn't confusion about the password link looking button-y (implying saving entered info) I'd consider this fixed.

Comment 5

[Tobias (:Tobbi) Markus]

Verified we have a Change Password link, not a button.